From owner-freebsd-hackers  Thu Nov 15 13:32:46 2001
Delivered-To: freebsd-hackers@freebsd.org
Received: from elvis.mu.org (elvis.mu.org [216.33.66.196])
	by hub.freebsd.org (Postfix) with ESMTP id 1803D37B418
	for <hackers@freebsd.org>; Thu, 15 Nov 2001 13:32:45 -0800 (PST)
Received: by elvis.mu.org (Postfix, from userid 1192)
	id D3C8C81D08; Thu, 15 Nov 2001 15:32:39 -0600 (CST)
Date: Thu, 15 Nov 2001 15:32:39 -0600
From: Alfred Perlstein <bright@mu.org>
To: Maxim Konovalov <maxim@macomnet.ru>
Cc: hackers@freebsd.org
Subject: Re: has 'options LOCKF_DEBUG' ever worked? (w/ patch) (fwd)
Message-ID: <20011115153239.T13393@elvis.mu.org>
References: <20011115233840.T38246-100000@news1.macomnet.ru>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <20011115233840.T38246-100000@news1.macomnet.ru>; from maxim@macomnet.ru on Thu, Nov 15, 2001 at 11:42:50PM +0300
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-hackers.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-hackers>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-hackers>
X-Loop: FreeBSD.ORG

Yes I saw this, I have no idea what 'JH' stands for either that's why
I left it as is.

The problem is that VTOI is ufs specific, this "fix" will break
LOCKF_DEBUG for all other FS's other than UFS because it casts
the vnode->data ptr to struct inode *.

So your "fix" is broken.

Please just fix lf_print to not deref the inode ptr in the struct.

-Alfred

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message