From owner-svn-src-all@freebsd.org Mon May 2 16:08:36 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 36CBBAEE5D7; Mon, 2 May 2016 16:08:36 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-oi0-f66.google.com (mail-oi0-f66.google.com [209.85.218.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 052DD1C7E; Mon, 2 May 2016 16:08:35 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-oi0-f66.google.com with SMTP id i2so27743204oib.3; Mon, 02 May 2016 09:08:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :date:message-id:subject:from:to:cc:content-transfer-encoding; bh=Y3ZE/WMq6tKXjaTyXyv2ugGSkrb808n2K9TOTVg24bQ=; b=N0kLQDhHyFvbrKoZQ+/m6l+q9P87K8UEXI+f3MOnJjPHiMQDdnsMyepqpOHAtkgipC Fuq3qFTwEc7PZqWojkfjEYlnpkDvxPIEyqC/u0BuZnrwZ2NhFLa8mS8fCVWtEYb6Fdp+ PGN2UfyawtJtwik3pOzAVxB9wx9vzIaS7rVx6G/UTnJnJC0P25P/NKiD0ZUGk81O+A9H m3wB5t6L08GtjLi5JebuWUf8obgvtKw4szdJemrAGgKXKSvH5dRntfX5to8jpS7qxekw ssitsLPl8Zcp8lHWKutU6UNdJD4NZbSMO/8miYwcwtnOqpDzzH9JwHyt2z0vOGis8seN oM5g== X-Gm-Message-State: AOPr4FX0RtQsXXVWfrZU05Chx/zQpfAKjHs4Xf3tVIiVjf4CyyVYZHj4uIRrCES/Ti4g/g== X-Received: by 10.157.40.9 with SMTP id m9mr16208717otb.23.1462205314589; Mon, 02 May 2016 09:08:34 -0700 (PDT) Received: from mail-oi0-f51.google.com (mail-oi0-f51.google.com. [209.85.218.51]) by smtp.gmail.com with ESMTPSA id tr6sm9580442obb.18.2016.05.02.09.08.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 May 2016 09:08:34 -0700 (PDT) Received: by mail-oi0-f51.google.com with SMTP id v145so162365030oie.0; Mon, 02 May 2016 09:08:33 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.202.86.79 with SMTP id k76mr15215091oib.22.1462205313763; Mon, 02 May 2016 09:08:33 -0700 (PDT) Reply-To: cem@FreeBSD.org Received: by 10.157.6.111 with HTTP; Mon, 2 May 2016 09:08:33 -0700 (PDT) In-Reply-To: References: <201605021507.u42F7hI3029685@repo.freebsd.org> <9AEBC481-D541-451F-82E0-7BCD571B0F93@FreeBSD.org> Date: Mon, 2 May 2016 09:08:33 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r298924 - head/usr.bin/sdiff From: Conrad Meyer To: Benjamin Kaduk Cc: "Bjoern A. Zeeb" , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 May 2016 16:08:36 -0000 On Mon, May 2, 2016 at 8:57 AM, Benjamin Kaduk wrote: > On Mon, May 2, 2016 at 10:54 AM, Bjoern A. Zeeb wrote: >> > On 02 May 2016, at 15:32 , Conrad Meyer wrote: >> > >> > Clang should really catch this too. Why didn=E2=80=99t it? >> >> It was only powerpc; sparc64 and mips were good as well. > > 'char' being signed vs. unsigned? Yeah, that occurred to me, but EOF should be out of range for any char type. I'd like ((char)getchar() =3D=3D EOF) to warn on all platforms. Best, Conrad