Date: Mon, 2 May 2016 09:08:33 -0700 From: Conrad Meyer <cem@FreeBSD.org> To: Benjamin Kaduk <bjkfbsd@gmail.com> Cc: "Bjoern A. Zeeb" <bz@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r298924 - head/usr.bin/sdiff Message-ID: <CAG6CVpX2DTAGyRXyndki0y5ZGzjpEudBhn9i8xN7N98qMCwGSQ@mail.gmail.com> In-Reply-To: <CAJ5_RoAosXjNe9gmAquY9MPCUy-R4uCQD3XkSuDTBSGcoJ6Fcg@mail.gmail.com> References: <201605021507.u42F7hI3029685@repo.freebsd.org> <CAG6CVpUUNW-LN7F117yfH1-zZVVSoaxMULiLS6ApfD%2BinPSEFg@mail.gmail.com> <9AEBC481-D541-451F-82E0-7BCD571B0F93@FreeBSD.org> <CAJ5_RoAosXjNe9gmAquY9MPCUy-R4uCQD3XkSuDTBSGcoJ6Fcg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, May 2, 2016 at 8:57 AM, Benjamin Kaduk <bjkfbsd@gmail.com> wrote: > On Mon, May 2, 2016 at 10:54 AM, Bjoern A. Zeeb <bz@freebsd.org> wrote: >> > On 02 May 2016, at 15:32 , Conrad Meyer <cem@FreeBSD.org> wrote: >> > >> > Clang should really catch this too. Why didn=E2=80=99t it? >> >> It was only powerpc; sparc64 and mips were good as well. > > 'char' being signed vs. unsigned? Yeah, that occurred to me, but EOF should be out of range for any char type. I'd like ((char)getchar() =3D=3D EOF) to warn on all platforms. Best, Conrad
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpX2DTAGyRXyndki0y5ZGzjpEudBhn9i8xN7N98qMCwGSQ>