Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 3 Nov 2024 05:17:58 -0800
From:      Rick Macklem <rick.macklem@gmail.com>
To:        Cy Schubert <Cy.Schubert@cschubert.com>
Cc:        Olivier Certner <olce@freebsd.org>, Ravi Pokala <rpokala@freebsd.org>, src-committers@freebsd.org,  dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject:   Re: cfbe7a62dc62 - main - nfs, rpc: Ensure kernel credentials have at least one group
Message-ID:  <CAM5tNy77wy_TD42WAK=j57bsf1iPWTj65Wc4cuaito4QYN5BSA@mail.gmail.com>
In-Reply-To: <20241103113308.D6D6B77@slippy.cwsent.com>
References:  <202411022039.4A2KdbAE046580@gitrepo.freebsd.org> <9307D0CC-6D10-4F86-AE3B-43E7D6DA19A9@panasas.com> <20241103065704.4377C114@slippy.cwsent.com> <3070589.hHqAuc6tWs@ravel> <20241103113308.D6D6B77@slippy.cwsent.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Nov 3, 2024 at 3:33=E2=80=AFAM Cy Schubert <Cy.Schubert@cschubert.c=
om> wrote:
>
> CAUTION: This email originated from outside of the University of Guelph. =
Do not click links or open attachments unless you recognize the sender and =
know the content is safe. If in doubt, forward suspicious emails to IThelp@=
uoguelph.ca.
>
>
> In message <3070589.hHqAuc6tWs@ravel>, Olivier Certner writes:
> > --nextPart2434776.THHZn3L5Ee
> > Content-Transfer-Encoding: 7Bit
> > Content-Type: text/plain; charset=3D"UTF-8"; protected-headers=3D"v1"
> > From: Olivier Certner <olce@freebsd.org>
> > Date: Sun, 03 Nov 2024 11:35:53 +0100
> > Message-ID: <3070589.hHqAuc6tWs@ravel>
> > In-Reply-To: <20241103065704.4377C114@slippy.cwsent.com>
> > MIME-Version: 1.0
> >
> > I now probably know what is going on and will post a patch soon (to fix=
 both
> > MINIMAL build and your panics).
> >
> > Is your "BREAK" kernel configuration omitting INET or NFSD?
>
> No. All it does is allow me to hit break (ctrl-e c l 1 using
> comms/com-console on serial console) to break to debugger any time while
> the server is running.
Since the nfscommon can be loaded as a module (ie. not always
present), I think you'll
need to use UID_NOBODY and GID_NOGROUP instead of nfsrv_XXX outside
of the nfs code. There is also the issue of it being NFSD_VNET(), which sho=
uld
not be used outside of the NFS code. It is currently just a VNET
variable, but bz@
was thinking of changing that someday.

Sorry I didn't spot this during the review, rick

>
>
> --
> Cheers,
> Cy Schubert <Cy.Schubert@cschubert.com>
> FreeBSD UNIX:  <cy@FreeBSD.org>   Web:  https://FreeBSD.org
> NTP:           <cy@nwtime.org>    Web:  https://nwtime.org
>
>                         e^(i*pi)+1=3D0
>
>
>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAM5tNy77wy_TD42WAK=j57bsf1iPWTj65Wc4cuaito4QYN5BSA>