Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 3 Oct 2019 08:08:40 -0600
From:      Adam Weinberger <adamw@adamw.org>
To:        =?UTF-8?Q?Romain_Tarti=C3=A8re?= <romain@freebsd.org>
Cc:        Marcelo Araujo <araujo@freebsd.org>, ports-committers <ports-committers@freebsd.org>,  svn-ports-all <svn-ports-all@freebsd.org>, svn-ports-head <svn-ports-head@freebsd.org>
Subject:   Re: svn commit: r513454 - head/sysutils/iocage
Message-ID:  <CAP7rwchgXiaBh7EqxQ%2Bhm8VwAq0v5vtF1eEBu%2BWerJ7B8=rSOg@mail.gmail.com>
In-Reply-To: <20191003081250.GA78318@blogreen.org>
References:  <201910010549.x915nMuB015138@repo.freebsd.org> <20191003081250.GA78318@blogreen.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Oct 3, 2019 at 2:18 AM Romain Tarti=C3=A8re <romain@freebsd.org> wr=
ote:
>
> Hi!
>
> On Tue, Oct 01, 2019 at 05:49:22AM +0000, Marcelo Araujo wrote:
> >   - The port works fine with devel/git too, we should first check if th=
ere
> >     is git installed, instead to assume we need to install git-lite. [1=
]
> > -             git-lite>0:devel/git-lite \
> > +             ${LOCALBASE}/bin/git:devel/git-lite \
>
>
> This does not help when building ports with poudriere.  Addding an
> OPTION to choose from git or git-lite would allow to build against the
> proper port and solve conflicts.

Good point Romain. Also, there is no reason to have ${LOCALBASE}/bin
in there. That path is used automatically.

# Adam


--=20
Adam Weinberger
adamw@adamw.org
https://www.adamw.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAP7rwchgXiaBh7EqxQ%2Bhm8VwAq0v5vtF1eEBu%2BWerJ7B8=rSOg>