From owner-cvs-all@FreeBSD.ORG Mon Nov 14 11:08:13 2011 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E82151065676; Mon, 14 Nov 2011 11:08:13 +0000 (UTC) (envelope-from bapt@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id B36638FC20; Mon, 14 Nov 2011 11:08:13 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id pAEB8DRA084443; Mon, 14 Nov 2011 11:08:13 GMT (envelope-from bapt@freebsd.org) Received: (from bapt@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id pAEB8DOD084442; Mon, 14 Nov 2011 11:08:13 GMT (envelope-from bapt@freebsd.org) X-Authentication-Warning: freefall.freebsd.org: bapt set sender to bapt@freebsd.org using -f Date: Mon, 14 Nov 2011 12:08:09 +0100 From: Baptiste Daroussin To: Chris Rees Message-ID: <20111114110809.GC2888@azathoth.lan> References: <201111130956.pAD9u85M053975@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="S1BNGpv0yoYahz37" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Ed Schouten , ports-committers@freebsd.org, cvs-ports@freebsd.org, cvs-all@freebsd.org, matthew@cashdollar.org Subject: Re: cvs commit: ports/shells/zsh/files patch-Src_watch.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Nov 2011 11:08:14 -0000 --S1BNGpv0yoYahz37 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Nov 13, 2011 at 10:45:35AM +0000, Chris Rees wrote: > On 13 November 2011 09:56, Baptiste Daroussin wrote: > > bapt =A0 =A0 =A0 =A02011-11-13 09:56:08 UTC > > > > =A0FreeBSD ports repository > > > > =A0Added files: > > =A0 =A0shells/zsh/files =A0 =A0 patch-Src_watch.c > > =A0Log: > > =A0- Fix build for badly upgraded systems which have both utmp.h and ut= mpx.h > > > > =A0PR: =A0 =A0 =A0 =A0 =A0 =A0 ports/156263 =A0http://www.FreeBSD.org/c= gi/query-pr.cgi?pr=3D156263 > > =A0Submitted by: =A0 Matthew Cashdollar > > =A0Feature safe: =A0 yes > > >=20 > Fixing it here will only mask the problem-- why are we adding a fix to > support a broken system? >=20 > The proper solution is to rm utmp.h in that system, is it not? >=20 > I suggest a different patch at [1]. >=20 > Chris >=20 > [1] http://www.bayofrum.net/~crees/patches/zsh-utmpx-fix.diff.txt > [removing the patchfile too] Well no I don't think, or you would have to add the same patch in lots of p= orts. In fact, I have been pondering for long what would be the best fix for this= =2E And if I need to provide a fix. Given that some people can use zsh for root (as I do :)) I think being able= to rebuild zsh a clean way before doing the make delete-old is nice, that is w= hy I did a fix that way. regards, Bapt --S1BNGpv0yoYahz37 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iEYEARECAAYFAk7A9pkACgkQ8kTtMUmk6EyFtACgmroQK9EEXdUnlce1smh6BtFd Hh8AoIkh1WDwNN+6QKttXx6TDUVFCv6G =XyKj -----END PGP SIGNATURE----- --S1BNGpv0yoYahz37--