From owner-freebsd-current@freebsd.org Fri Feb 2 10:44:02 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 08F68ECF7D5 for ; Fri, 2 Feb 2018 10:44:02 +0000 (UTC) (envelope-from freebsd@grem.de) Received: from mail.grem.de (outcast.grem.de [213.239.217.27]) by mx1.freebsd.org (Postfix) with SMTP id 69C7885A14 for ; Fri, 2 Feb 2018 10:44:00 +0000 (UTC) (envelope-from freebsd@grem.de) Received: (qmail 32440 invoked by uid 89); 2 Feb 2018 10:37:18 -0000 Received: from unknown (HELO bsd64.grem.de) (mg@grem.de@80.190.102.231) by mail.grem.de with ESMTPA; 2 Feb 2018 10:37:18 -0000 Date: Fri, 2 Feb 2018 11:37:17 +0100 From: Michael Gmelin To: Bridger Dyson-Smith Cc: Jan Bramkamp , freebsd-current@freebsd.org, "Rodney W. Grimes" Subject: Re: Lenovo T470s Questions Message-ID: <20180202113717.5dff994f@bsd64.grem.de> In-Reply-To: References: X-Mailer: Claws Mail 3.15.1 (GTK+ 2.24.31; amd64-portbld-freebsd10.3) X-Face: $wrgCtfdVw_H9WAY?S&9+/F"!41z'L$uo*WzT8miX?kZ~W~Lr5W7v?j0Sde\mwB&/ypo^}> +a'4xMc^^KroE~+v^&^#[B">soBo1y6(TW6#UZiC]o>C6`ej+i Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWJBwe5BQDl LASZU0/LTEWEfHbyj0Txi32+sKrp1Mv944X8/fm1rS+cAAAACXBIWXMAAAsTAAAL EwEAmpwYAAAAB3RJTUUH3wESCxwC7OBhbgAAACFpVFh0Q29tbWVudAAAAAAAQ3Jl YXRlZCB3aXRoIFRoZSBHSU1QbbCXAAAAAghJREFUOMu11DFvEzEUAGCfEhBVFzuq AKkLd0O6VrIQsLXVSZXoWE5N1K3DobBBA9fQpRWc8OkWouaIjedWKiyREOKs+3PY fvalCNjgLVHeF7/3bMtBzV8C/VsQ8tecEgCcDgrzjekwKZ7TwsJZd/ywEKwwP+ZM 8P3drTsAwWn2mpWuDDuYiK1bFs6De0KUUFw0tWxm+D4AIhuuvZqtyWYeO7jQ4Aea 7jUqI+ixhQoHex4WshEvSXdood7stlv4oSuFOC4tqGcr0NjEqXgV4mMJO38nld4+ xKNxRDon7khyKVqY7YR4d+Cg0OMrkWXZOM7YDkEfKiilCn1qYv4mighZiynuHHOA Wq9QJq+BIES7lMFUtcikMnkDGHUoncA+uHgrP0ctIEqfwLHzeSo+eUA66AqzwN6n 2ZHJhw6Qh/PoyC/QENyEyC/AyNjq74Bs+3UH0xYwzDUC4B97HgLocg1QLYgDDO1v f3UX9Y307Ew4AHh67YAFFsxEpkXwpXY3eIgMhAAE3R19L919nNnuD2wlPcDE3UeT L2ytEICQib9BXgS2fU8PrD82ToYO1OEmMSnYTjSqSv9wdC0tPYC+rQRQD9ESnldF CyqfmiYW+tlALt8gH2xrMdC/youbjzPXEun+/ReXsMCDyve3dZc09fn2Oas8oXGc Jj6/fOeK5UmSMPmf/jL+GD8BEj0k/Fn6IO4AAAAASUVORK5CYII= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Feb 2018 10:44:02 -0000 On Fri, 2 Feb 2018 11:11:15 +0100 Jan Bramkamp wrote: > On 02.02.18 03:13, Bridger Dyson-Smith wrote: > > Hi list and Michael - > >=20 > > I received a T470s at work and decided to jump into the CURRENT end > > of the FreeBSD pool. I have a weird acpi_ibm issue and I'm not sure > > where to start trying to diagnose the issue. > >=20 > > # uname -a > > FreeBSD spanner 12.0-CURRENT FreeBSD 12.0-CURRENT #0 r328126: Thu > > Jan 18 15:25:44 UTC 2018 root@releng3.nyi.freebsd.org:/ > > usr/obj/usr/src/amd64.amd64/sys/GENERIC amd64 > >=20 > > I've loaded acpi_ibm via /boot/loader.conf: > > acpi_ibm_load=3D"YES" > >=20 > > and the module shows as being loaded: > > # kldstat | grep acpi_ibm > > 8 1 0xffffffff8278e000 7570 acpi_ibm.ko > >=20 > > However, I don't have any of the sysctl knobs available; e.g. > > # sysctl -a | grep acpi_ibm > > # > >=20 > > or > > # sysctl dev.acpi_ibm.0.fan_speed > > sysctl: unknown oid 'dev.acpi_ibm.0.fan_speed' > >=20 > > I've (tried) to look through the commit messages on svn-src-head, > > but I'm not seeing anything specifically related to acpi work, or I > > just don't know what I'm looking at (a definite possibility). =20 >=20 > I made the same discovery on my T470s running FreeBSD 12-CURRENT. It > has been a long time since Thinkpads were designed by IBM. The fan > control works just fine without any special purpose module. The > acpi_ibm module main usecase for me was always handling the special > button events, but these days they are just secondary function on the > regular function keys. Who needs an additional row of buttons on >2k=E2= =82=AC > laptop when you can waste the space on a large useless trackpad. I personally love having a large, well built trackpad *and* function keys. That aside, I've been working on a patch to acpi_ibm to support special button events, bluetooth on/off and controlling the keyboard backlight (not just for the T470s, but also for other recent Lenovo models). I still need to update the man page and polish it, but it's already available in a code review and I use it myself successfully (I didn't look into things like fan control though, as those really shouldn't be touched these days): https://reviews.freebsd.org/D14103 Direct link to the patch: https://reviews.freebsd.org/D14103?download=3Dtrue Testers and code reviews are welcome. Best, Michael p.s. Make sure to load the correct kernel module in case you rebuilt it individually. --=20 Michael Gmelin