From owner-freebsd-doc Fri Oct 4 18: 0:17 2002 Delivered-To: freebsd-doc@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 76E9537B404 for ; Fri, 4 Oct 2002 18:00:13 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id A823A43E6E for ; Fri, 4 Oct 2002 18:00:12 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id g9510CCo033475 for ; Fri, 4 Oct 2002 18:00:12 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.6/8.12.6/Submit) id g9510CRc033474; Fri, 4 Oct 2002 18:00:12 -0700 (PDT) Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B8C1637B401 for ; Fri, 4 Oct 2002 17:55:31 -0700 (PDT) Received: from angelica.unixdaemons.com (angelica.unixdaemons.com [209.148.64.135]) by mx1.FreeBSD.org (Postfix) with ESMTP id 005C343E65 for ; Fri, 4 Oct 2002 17:55:31 -0700 (PDT) (envelope-from hiten@angelica.unixdaemons.com) Received: from angelica.unixdaemons.com (hiten@localhost.unixdaemons.com [127.0.0.1]) by angelica.unixdaemons.com (8.12.5/8.12.1) with ESMTP id g94NhlVI044020 for ; Fri, 4 Oct 2002 19:43:47 -0400 (EDT) Received: (from hiten@localhost) by angelica.unixdaemons.com (8.12.5/8.12.1/Submit) id g94NhlvQ044019; Fri, 4 Oct 2002 19:43:47 -0400 (EDT) (envelope-from hiten) Message-Id: <200210042343.g94NhlvQ044019@angelica.unixdaemons.com> Date: Fri, 4 Oct 2002 19:43:47 -0400 (EDT) From: Hiten Pandya Reply-To: Hiten Pandya To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: docs/43678: [PATCH] Updates for the pciconf(8) manual page Sender: owner-freebsd-doc@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org >Number: 43678 >Category: docs >Synopsis: [PATCH] Updates for the pciconf(8) manual page >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-doc >State: open >Quarter: >Keywords: >Date-Required: >Class: doc-bug >Submitter-Id: current-users >Arrival-Date: Fri Oct 04 18:00:11 PDT 2002 >Closed-Date: >Last-Modified: >Originator: Hiten Pandya >Release: FreeBSD 4.6-STABLE i386 >Organization: >Environment: Not applicable. >Description: The pciconf(8) manual page, presents the '-l' option as usable a non-root user; which, is not true. I have tried this on a two FreeBSD systems, one with FreeBSD 5.0-CURRENT (20020818-JPSNAP), and a FreeBSD 4.6-STABLE system. In the patch provided, it corrects the mistake. Secondly, the man page describes, under the BUGS section about, providing non-root access to the '-a' and '-r' options. I do not think this is possible, because of the kldload command, and other reason(s) outlined in the paragraph. The patch removes the statements described above. I have made two versions of the patch. The first one: http://www.unixdaemons.com/~hiten/work/diffs/pciconf.8.first ^^^ Removes the (false) information regarding the '-l' command line parameter to pciconf(8). NOTE, it does not contain a fix to the _second_ problem I outlined. If there is interest in the second problem, then, please fetch the patch provided from the location below, (NOTE: it fixes both the problems): http://www.unixdaemons.com/~hiten/work/diffs/pciconf.8.second Thanking in Advance. -- Hiten Pandya -- hiten@uk.FreeBSD.org, hiten@softweyr.com >How-To-Repeat: Execute the pciconf(8) utility as non-root, and it will result in: "pciconf: /dev/pci: Permission denied". This error can be noticed, both, on -current, and -stable. >Fix: Apply the patch provided, to fix both of the problems that are described above (patch same as second URL). NOTE, this patch _SHOULD_ be MFC'ed, because it applies to -current, and -stable. Index: pciconf.8 =================================================================== RCS file: /home/ncvs/src/usr.sbin/pciconf/pciconf.8,v retrieving revision 1.22 diff -u -r1.22 pciconf.8 --- pciconf.8 2002/09/17 18:10:39 1.22 +++ pciconf.8 2002/10/01 22:54:39 @@ -108,11 +108,10 @@ device, which contains several (similar or independent) functions on one chip. .Pp -The -.Fl l -option is the only one available to non-root users. -All other invocations of +All invocations of .Nm +except for +.Fl l require a .Ar selector of the form @@ -200,15 +199,3 @@ .Nm , but not in the underlying .Xr ioctl 2 . -.Pp -It might be useful to give non-root users access to the -.Fl a -and -.Fl r -options. -But only root will be able to execute a -.Nm kldload -to provide the device with a driver KLD, and reading of configuration space -registers may cause a failure in badly designed -.Tn PCI -chips. >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-doc" in the body of the message