From owner-freebsd-current@FreeBSD.ORG Wed Nov 12 16:52:42 2014 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1CBB0C0 for ; Wed, 12 Nov 2014 16:52:42 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EA1D0A7E for ; Wed, 12 Nov 2014 16:52:41 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 0CCFCB945; Wed, 12 Nov 2014 11:52:41 -0500 (EST) From: John Baldwin To: Henry Hu Subject: Re: r273918 buildworld broke at semaphore Date: Wed, 12 Nov 2014 11:51:05 -0500 User-Agent: KMail/1.13.5 (FreeBSD/8.4-CBSD-20140415; KDE/4.5.5; amd64; ; ) References: <1414786086662-5961241.post@n5.nabble.com> <201411111333.05910.jhb@freebsd.org> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201411121151.05374.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Wed, 12 Nov 2014 11:52:41 -0500 (EST) Cc: FreeBSD CURRENT , Beeblebrox X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Nov 2014 16:52:42 -0000 On Tuesday, November 11, 2014 4:22:05 pm Henry Hu wrote: > On Tue, Nov 11, 2014 at 1:33 PM, John Baldwin wrote: > > > On Friday, October 31, 2014 4:08:06 pm Beeblebrox wrote: > > > First breakage in a long time. Error is: > > > > > > In file included from cancelpoints_sem_new.c:47: > > > /usr/src/lib/libc/../../include/semaphore.h:41:16: error: field has > > > incomplete type 'struct _usem2' > > > struct _usem2 _kern; > > > ^ > > > /usr/src/lib/libc/../../include/semaphore.h:41:9: note: forward > > declaration > > > of 'struct _usem2' > > > struct _usem2 _kern; > > > ^ > > > cancelpoints_sem_new.c:66:33: error: use of undeclared identifier > > > 'USEM_MAX_COUNT' > > > _Static_assert(SEM_VALUE_MAX <= USEM_MAX_COUNT, "SEM_VALUE_MAX too > > large"); > > > ^ > > > cancelpoints_sem_new.c:335:15: warning: implicit declaration of function > > > 'USEM_COUNT' is invalid in C99 [-Wimplicit-function-declaration] > > > *sval = (int)USEM_COUNT(sem->_kern._count); > > > ^ > > > cancelpoints_sem_new.c:342:23: error: use of undeclared identifier > > > 'UMTX_OP_SEM2_WAKE' > > > return _umtx_op(sem, UMTX_OP_SEM2_WAKE, 0, NULL, NULL); > > > ^ > > > cancelpoints_sem_new.c:361:23: error: use of undeclared identifier > > > 'UMTX_OP_SEM2_WAIT' > > > return _umtx_op(sem, UMTX_OP_SEM2_WAIT, 0, > > > ^ > > > cancelpoints_sem_new.c:445:14: error: use of undeclared identifier > > > 'USEM_HAS_WAITERS' > > > if (count & USEM_HAS_WAITERS) > > > ^ > > > 1 warning and 5 errors generated. > > > > Seems like your tree is not fully up to date? The changes to sem_new.c > > were > > committed in the same commit as the changes to sys/umtx.h. > > > Maybe it's another problem. buildworld may be picking up umtx.h from > /usr/include which is the old version. 'make buildworld' should always populate an include tree under /usr/obj that is used instead of /usr/include. If this wasn't correct, then every change to add new constants, etc. to any header installed to /usr/include would fail to build. -- John Baldwin