From owner-freebsd-embedded@FreeBSD.ORG Thu Jul 4 16:09:13 2013 Return-Path: Delivered-To: freebsd-embedded@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id CE007923 for ; Thu, 4 Jul 2013 16:09:13 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from mail-ie0-f173.google.com (mail-ie0-f173.google.com [209.85.223.173]) by mx1.freebsd.org (Postfix) with ESMTP id 9D6171EF8 for ; Thu, 4 Jul 2013 16:09:13 +0000 (UTC) Received: by mail-ie0-f173.google.com with SMTP id k13so3474202iea.18 for ; Thu, 04 Jul 2013 09:09:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to:x-mailer :x-gm-message-state; bh=RgpZsC7tmNHq59IEg2L1sqyoJPtU9EX/4v1I6TXxe+s=; b=bSI7iaAKfogdxQPFVQWl661OWIwBzZt7Wq2XxfzfqYm6Lj41oltTg1/WLVPGnXcCmW FeEPAA5oeLxNsT30Iu8cnokISquY4Dsjp0WaYL0Q1TOEkQZDeocZiWi/Uw+mHi8puu2b TBP372fgjc7tiIY9Z60YhsgDwwztJBhMCPh/QZhikLMbBoF7XpiYX8pXk+TiurPtU/87 ZjlQLEuY6f6recN4GEWJlP8fiPYjoaT1PCz06sjy4XThyErsus5EtdGaqe34to/zYcgQ TH/o7gX732tvQaGzTdCRpLbN9yx1SEh5Tl0zmnfFi4uXPNoTkxqsPBIL00Y0iiGdLQrq 03dg== X-Received: by 10.50.130.113 with SMTP id od17mr3173139igb.10.1372954152980; Thu, 04 Jul 2013 09:09:12 -0700 (PDT) Received: from 53.imp.bsdimp.com (50-78-194-198-static.hfc.comcastbusiness.net. [50.78.194.198]) by mx.google.com with ESMTPSA id hj6sm27795475igb.1.2013.07.04.09.09.11 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 04 Jul 2013 09:09:11 -0700 (PDT) Sender: Warner Losh Subject: Re: [PATCH] SDIO support for Globalscale Dreamplug Mime-Version: 1.0 (Apple Message framework v1085) Content-Type: text/plain; charset=us-ascii From: Warner Losh In-Reply-To: <51D50C55.1040300@myspectrum.nl> Date: Thu, 4 Jul 2013 10:09:09 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: <16DEBC38-F99A-4733-86FD-9E81A146CE5C@bsdimp.com> References: <20130702145905.GA1847@olymp.kibab.com> <51D3097A.8010601@FreeBSD.org> <51D3282C.1090701@bakulin.de> <20130703222002.GA60491@olymp.kibab.com> <51D50C55.1040300@myspectrum.nl> To: Jeroen Hofstee X-Mailer: Apple Mail (2.1085) X-Gm-Message-State: ALoCoQnO6PcuAfnOEhDj5WIFU9ajhFq6x6eDxp5zv6aN7KdNSuAmq/umVRIaEQWm66cCuZVCIi+N Cc: Alexander Motin , Ilya Bakulin , freebsd-arm@freebsd.org, freebsd-embedded@freebsd.org X-BeenThere: freebsd-embedded@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Dedicated and Embedded Systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Jul 2013 16:09:13 -0000 On Jul 3, 2013, at 11:47 PM, Jeroen Hofstee wrote: > Hello Ilya, >=20 > On 07/04/2013 12:20 AM, Ilya Bakulin wrote: >> So some bytes lack 0x40... This problem occurs also with other = numbers >> read from the card, for example, vendor ID is read as 0x029F instead = of 0x02DF. >=20 >> +/* Halfword bit masks used for command response extraction. */ >> +#define MV_SDIO_RSP48_BM2 0x0002 /* Lower 2 bits. */ >> +#define MV_SDIO_RSP48_BM6 0x003f /* Lower 6 bits. */ >=20 >> + /* Response bits [15:14] and [13:8] */ >> + *rp++ =3D (resp[2] & MV_SDIO_RSP48_BM6) | >> + ((word & MV_SDIO_RSP48_BM2) << 6); >> + >=20 > =46rom the looks if it, MV_SDIO_RSP48_BM2 must be 3 instead 2. And 0x0031 doesn't look right either... I'd have expected 0x3f. Warner