Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 15 Dec 2017 20:24:51 +0100
From:      "Tobias C. Berner" <tcberner@gmail.com>
To:        "Sergey A. Osokin" <osa@freebsd.org>
Cc:        Jochen Neumeister <joneum@freebsd.org>, ports-committers@freebsd.org,  svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r456286 - head/www/nginx
Message-ID:  <CAOshKteziQnzdjaV5xuZgT6GqX=PNu5-x78aAFut2x2bo6s3BA@mail.gmail.com>
In-Reply-To: <20171215004922.GD81079@FreeBSD.org>
References:  <201712141007.vBEA74si099181@repo.freebsd.org> <20171215004922.GD81079@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Hi Sergey

Jochen did it correctly -- the porters handbook [1] clearly states:
""PORTREVISION must be increased each time a change is made to the port
that changes the generated package in any way.
*That includes changes that only affect a package built with non-default
options
<https://www.freebsd.org/doc/en/books/porters-handbook/book.html#makefile-options>."*


mfg Tobias

[1] https://www.freebsd.org/doc/en/books/porters-handbook/
book.html#makefile-portrevision

On 15 December 2017 at 01:49, Sergey A. Osokin <osa@freebsd.org> wrote:

> Hi Jochen,
>
> fancyindex is a third-party module, it isn't enabled by default,
> so no reason to bump PORTREVISION in this case.
>
> --
> Sergey A. Osokin
>
> On Thu, Dec 14, 2017 at 10:07:04AM +0000, Jochen Neumeister wrote:
> > Author: joneum
> > Date: Thu Dec 14 10:07:04 2017
> > New Revision: 456286
> > URL: https://svnweb.freebsd.org/changeset/ports/456286
> >
> > Log:
> >   www/nginx: Update fancyindex to 0.4.2
> >
> >   This release contains an important fix which can cause Nginx
> >   to crash when a directory contains zero-sized (empty) files.
> >   This bug has been present in all previous releases,
> >   and all users are strongly encouraged to update to version 0.4.2.
> >
> >   PR:         224237
> >   Submitted by:       wosch
> >   Approved by:        tz (mentor)
> >   MFH:                2017Q4
> >   Differential Revision:      https://reviews.freebsd.org/D13486
> >
> > Modified:
> >   head/www/nginx/Makefile
> >   head/www/nginx/distinfo
> >
> > Modified: head/www/nginx/Makefile
> > ============================================================
> ==================
> > --- head/www/nginx/Makefile   Thu Dec 14 09:31:09 2017        (r456285)
> > +++ head/www/nginx/Makefile   Thu Dec 14 10:07:04 2017        (r456286)
> > @@ -3,7 +3,7 @@
> >
> >  PORTNAME=    nginx
> >  PORTVERSION= 1.12.2
> > -PORTREVISION?=       2
> > +PORTREVISION?=       3
> >  PORTEPOCH=   2
> >  CATEGORIES=  www
> >  MASTER_SITES=        http://nginx.org/download/
> > @@ -529,7 +529,7 @@ CONFIGURE_ARGS+=--add-module=${WRKSRC_eval}
> >  .endif
> >
> >  .if ${PORT_OPTIONS:MHTTP_FANCYINDEX}
> > -NGINX_FANCYINDEX_VERSION=    0.4.1
> > +NGINX_FANCYINDEX_VERSION=    0.4.2
> >  GH_ACCOUNT+= aperezdc:fancyindex
> >  GH_PROJECT+= ngx-fancyindex:fancyindex
> >  GH_TAGNAME+= v${NGINX_FANCYINDEX_VERSION}:fancyindex
> >
> > Modified: head/www/nginx/distinfo
> > ============================================================
> ==================
> > --- head/www/nginx/distinfo   Thu Dec 14 09:31:09 2017        (r456285)
> > +++ head/www/nginx/distinfo   Thu Dec 14 10:07:04 2017        (r456286)
> > @@ -1,4 +1,4 @@
> > -TIMESTAMP = 1512144757
> > +TIMESTAMP = 1513235728
> >  SHA256 (nginx-1.12.2.tar.gz) = 305f379da1d5fb5aefa79e45c82985
> 2ca6983c7cd2a79328f8e084a324cf0416
> >  SIZE (nginx-1.12.2.tar.gz) = 981687
> >  SHA256 (ngx_cache_purge-2.3.tar.gz) = 279e0d8a46d3b1521fd43b3f78bc1c
> 08b263899142a7cc5058c1c0361a92c89c
> > @@ -47,8 +47,8 @@ SHA256 (arut-nginx-dav-ext-module-v0.0.3_GH0.tar.gz) =
> >  SIZE (arut-nginx-dav-ext-module-v0.0.3_GH0.tar.gz) = 6260
> >  SHA256 (openresty-nginx-eval-module-342c812_GH0.tar.gz) =
> c45f6438474593f0cf5229160327d20c2f2d72e9c0b5c8cf9e0ef8d5295de177
> >  SIZE (openresty-nginx-eval-module-342c812_GH0.tar.gz) = 14183
> > -SHA256 (aperezdc-ngx-fancyindex-v0.4.1_GH0.tar.gz) =
> 2b00d8e0ad2a67152a9cee7b7ee67990c742d501412df912baaf1eee9bb6dc71
> > -SIZE (aperezdc-ngx-fancyindex-v0.4.1_GH0.tar.gz) = 21130
> > +SHA256 (aperezdc-ngx-fancyindex-v0.4.2_GH0.tar.gz) =
> 8327150864ca267b735d550d3304030efbbd863fdddfe0a94e970f249a8827ee
> > +SIZE (aperezdc-ngx-fancyindex-v0.4.2_GH0.tar.gz) = 22047
> >  SHA256 (alibaba-nginx-http-footer-filter-1.2.2_GH0.tar.gz) =
> 3493b54460c59370f9f60c6e662862752f1920fc6e684f7a66bb2b3260692813
> >  SIZE (alibaba-nginx-http-footer-filter-1.2.2_GH0.tar.gz) = 3934
> >  SHA256 (leev-ngx_http_geoip2_module-2.0_GH0.tar.gz) =
> ebb4652c4f9a2e1ee31fddefc4c93ff78e651a4b2727d3453d026bccbd708d99
> >
>
>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOshKteziQnzdjaV5xuZgT6GqX=PNu5-x78aAFut2x2bo6s3BA>