From nobody Tue Feb 18 13:54:43 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Yy1HC4thWz5ndnt; Tue, 18 Feb 2025 13:54:47 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Yy1HC4JRwz3qm0; Tue, 18 Feb 2025 13:54:47 +0000 (UTC) (envelope-from kp@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1739886887; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3Ta62n1TZCgwfETdL0sMIKX/FToLoiivDObHGMNjEiI=; b=MuTR/fQ4mnKmLQk95Il3izQi86x3fVBk/EaVTmYHJLi/QEGqcYOn3+uSOlpqnGjYq1nqoe XnVnsxeMuetugLFnPLQU1gO78NM33J5m1i6UxXil47nSQz4moM3itSj8UT4YTOqEYPAsQv 9znbQIRsyj5fcf4sLqJrBkLl/XKVe6VB9iJG0KK+29w9dQLzQKcPcSvHNPK+H9sey1ZHBD PJ5tl7JYC6MKZEo1QiKxfomPd3Zp8c4INQFo2Lf/9dUIad3PJeJdzrQovWd3fu1bEb/3dq lmvJGiI9HyqOVHvDpSJYqBbgikVhxO77NAzMwzPuwFJLpXERJjHfAkBERgzxpQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1739886887; a=rsa-sha256; cv=none; b=sHuVOhL6ZZeftJSZRAv2zUyEZH/PtORAIS+sTDV8cnS/SeDBB2RVzFT29NHYcaB4J3dMyu 0SUu+pypwgjwVw6knlypVBvlpuQFMBuXQFIGKJoTzzl8AvusfvT+yY3I306H+RA71Z+46A wDMmVZQk3jjdHHZ91f5zuexu74udVWjBekbmHWTp015Uz7fenu+vw3YYcltmlGEwKgQHPx HVcq2O+HwHbmmL5QG43N5LgwGIceLzFunrxOv6OWBITzOPBoqAntlQkQ3HmRMhMzYa3UJS 0hGj4uT5wvJd1Z12we0bYkDNJcoB14vTAZA9Al0mbQYtlBXG1Tmi7EdbF3nRiw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1739886887; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3Ta62n1TZCgwfETdL0sMIKX/FToLoiivDObHGMNjEiI=; b=XrKDnn2ExBJq6YX0QbnIC5GhTTFa6kZAMDZGsRKuQ56O60T3QPMF6Fp40ga1Qgtnosv+BR fcIRnQIwUC3VbWeuZT2OcgBkf8itLE+x6OjNy8VHXiAX4CTvjknDGhY3SgrerchUknjoKm i3srT5mFT7OOEYDJ8u+sRLnKqBHmbHIiM6lVkYHxgY9dvRsGJ3EjcAhV/UCNQRMwJM2PFp utxXjHilGkLPc6bm2DQdbSingoqfS3iE+yJJ9b+joJL8lcP+H43wdp2L5vhkEF9/75E6b/ XpQPmxM8IoY/qGOvUxs1OE9eaLuhfFS9kN2Vbf+pMTA8z3VTAoDq+Bt9x6bEuw== Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx1.codepro.be", Issuer "R10" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Yy1HC2zPbzq9C; Tue, 18 Feb 2025 13:54:47 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id 4E61624E44; Tue, 18 Feb 2025 14:54:44 +0100 (CET) From: Kristof Provost To: Warner Losh Cc: John Baldwin , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 7e7f88001d7d - main - pf: use time_t for storing time_t values Date: Tue, 18 Feb 2025 14:54:43 +0100 X-Mailer: MailMate (2.0r6222) Message-ID: <5BE3DFA0-33A8-4E60-B4C7-677E1064F930@FreeBSD.org> In-Reply-To: References: <202502141750.51EHoOFm061342@gitrepo.freebsd.org> <5c019c51-949b-4255-bc44-926ac973a1af@FreeBSD.org> <1B3E8B07-037B-4DA9-A8D7-81F866078A39@FreeBSD.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 17 Feb 2025, at 22:03, Warner Losh wrote: > On Mon, Feb 17, 2025, 10:08=E2=80=AFAM Kristof Provost = wrote: > >> On 17 Feb 2025, at 16:24, John Baldwin wrote: >> >> On 2/14/25 12:50, Kristof Provost wrote: >> >> The branch main has been updated by kp: >> >> URL: >> https://cgit.FreeBSD.org/src/commit/?id=3D7e7f88001d7dfec83cd7568369be= 6a587d4a51ff >> >> commit 7e7f88001d7dfec83cd7568369be6a587d4a51ff >> Author: Kristof Provost kp@FreeBSD.org >> AuthorDate: 2025-02-07 10:29:26 +0000 >> Commit: Kristof Provost kp@FreeBSD.org >> CommitDate: 2025-02-14 17:47:52 +0000 >> >> pf: use time_t for storing time_t values >> No change to the underlying type, so no ABI change. >> We define __time_t as uint64_t if __LP64__, otherwise uint32_t, >> and only define __LP64__ if long is 64 bits. >> In other words: __time_t =3D=3D long. >> ok henning@ deraadt@ >> Obtained from: OpenBSD, guenther , 6c1b69a= 0ff >> Sponsored by: Rubicon Communications, LLC ("Netgate") >> Differential Revision: https://reviews.freebsd.org/D48963 >> >> This is an ABI change on non-i386 32-bit platforms in FreeBSD since th= ey >> all use a 64-bit type for time_t that is not the same size as long. No= t >> sure if the ABI change matters on FreeBSD though? >> >> It wasn=E2=80=99t intended to be an ABI change, hence the commit messa= ge. It >> appears that=E2=80=99s only correct for x86 though. >> > > Yes. It may have been true in openbsd land, but not FreeBSD. > >> So we=E2=80=99re only talking about armv7 and ppc32, if I=E2=80=99m no= t forgetting >> anything. The former is on the removal list already, and the latter ..= >> well, I don=E2=80=99t know how many users there are. Both are likely t= o be embedded >> platforms where the ABI change is going to be even less relevant (beca= use >> it really only matters if the kernel and userspace are not updated >> together, and these are going to be embedded devices that are far more= >> likely to have everything updated simultaneously). >> > > Armv7 will be around in 15. Ppc32 is likely going away. > >> So I=E2=80=99m unsure about what to do. I can revert this and we can j= ust carry >> this (trivial) diff to OpenBSD forever, or we can ignore the ABI break= age >> given the above. I=E2=80=99m not inclined to do anything more involved= though. >> >> Do you have any thoughts? >> > I think the diffs to OpenBSD are most undesirable of the alternatives. > > Major os breakage is fine. Tier2 platforms get a weaker version of > compatibility. > > Armv7 is on the cusp of the abi needing to work. Sonce this is a privat= e > abi, and only a few programs are affected and they already need an upda= te > for 15 due to other changes (right?) And since providing backwards > compatible ABI shims looks to be kinda nontrivial, I agree with the oth= ers: > document in release notes and don't MFC and we're likrly good. > How does https://reviews.freebsd.org/D49046 look? This will not be MFC=E2=80=99d. There=E2=80=99s an entire series of OpenB= SD patches that this is part of that will not be MFCd. Best regards, Kristof