Date: Wed, 3 Mar 2004 18:59:48 +0200 From: Ruslan Ermilov <ru@FreeBSD.org> To: Yar Tikhiy <yar@FreeBSD.org> Cc: net@FreeBSD.org Subject: Re: cvs commit: src/sys/netgraph ng_vlan.c ng_vlan.h src/sys/modules/netgraph Makefile src/sys/modules/netgraph/vlan Makefile src/share/man/man4 Makefile ng_vlan.4 Message-ID: <20040303165948.GA22163@ip.net.ua> In-Reply-To: <20040303154554.GA51549@comp.chem.msu.su> References: <200403011722.i21HMG1h016273@repoman.freebsd.org> <20040303154554.GA51549@comp.chem.msu.su>
next in thread | previous in thread | raw e-mail | index | archive | help
--envbJBWh7q8WU6mo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hey Yar, I'm sending my reply to a public mailing list mainly to archive it, but also in a hope to attract some interested developer's attention. On Wed, Mar 03, 2004 at 06:45:55PM +0300, Yar Tikhiy wrote: > Greetings Ruslan, >=20 > On Mon, Mar 01, 2004 at 09:22:16AM -0800, Ruslan Ermilov wrote: > > ru 2004/03/01 09:22:16 PST > >=20 > > FreeBSD src repository > >=20 > > Modified files: > > sys/modules/netgraph Makefile=20 > > share/man/man4 Makefile=20 > > Added files: > > sys/netgraph ng_vlan.c ng_vlan.h=20 > > sys/modules/netgraph/vlan Makefile=20 > > share/man/man4 ng_vlan.4=20 > > Log: > > Netgraph node type for IEEE 802.1Q VLAN tagging. >=20 > Do I understand right that such issues as VLAN-level multicast > filtering and hardware tagging, which are handled by if_vlan, can't > be addressed by ng_vlan due to the nature of Netgraph? >=20 One needs real Ethernet hardware to program its multicast filter. In case of vlan(4) this is the parent interface. In the Netgraph case, the node connected to the "lower" hook is not necessarily ng_ether(4), yet ng_ether(4) doesn't support programming its multicast filter through Netgraph control messages. Similarly with h/w tagging: while ng_vlan(4) supports de-tagging of hardware supplied tags, it doesn't add tags suitable for h/w that support h/w VLAN tagging because it does not know what hardware it's connected to (it may be connected indirectly, or may be not connected to any real hardware at all, after all). It should be pretty easy though to add a new control message to program ng_vlan(4) to supply VLAN tags in the form suitable for hardware that supports it, rather than encapsulating header into ETHERTYPE_VLAN. It's just that I didn't need this functionality. If somebody needs it, it should be pretty trivial to implement, and I would be happy to review, test, and commit such a patch. Cheers, --=20 Ruslan Ermilov FreeBSD committer ru@FreeBSD.org --envbJBWh7q8WU6mo Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFARg8EUkv4P6juNwoRArwtAJ46kEdqT9GP3w01bDxVRcJnX3ypBwCfcRNf ktBnVSyoXAtvTWQqDmVbsO4= =jxdF -----END PGP SIGNATURE----- --envbJBWh7q8WU6mo--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040303165948.GA22163>