From owner-freebsd-current@FreeBSD.ORG Tue Jul 12 07:26:20 2005 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D10ED16A41C for ; Tue, 12 Jul 2005 07:26:20 +0000 (GMT) (envelope-from nike_d@cytexbg.com) Received: from office.suresupport.com (office.suresupport.com [213.145.98.15]) by mx1.FreeBSD.org (Postfix) with SMTP id E3B1343D4C for ; Tue, 12 Jul 2005 07:26:19 +0000 (GMT) (envelope-from nike_d@cytexbg.com) Received: (qmail 96954 invoked by uid 1026); 12 Jul 2005 07:27:41 -0000 Received: from 213.145.98.14 by office.suresupport.com (envelope-from , uid 1004) with qmail-scanner-1.23 (f-prot: 4.4.2/3.14.11. Clear:RC:1(213.145.98.14):. Processed in 0.096107 secs); 12 Jul 2005 07:27:41 -0000 Received: from unknown (HELO 14.98.145.213.in-addr.arpa) (213.145.98.14) by office.suresupport.com with SMTP; 12 Jul 2005 07:27:40 -0000 From: Niki Denev To: freebsd-current@freebsd.org Date: Tue, 12 Jul 2005 10:26:16 +0300 User-Agent: KMail/1.8 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200507121026.16664.nike_d@cytexbg.com> Subject: add a few informative printfs to if_bridge.c? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jul 2005 07:26:20 -0000 Hello all, I've had some problems adding one if_ral interface to if_bridge device. I've tracked down the problem to the MTU on my PCI if_ral interface which is set to 2290 ( i think that hostapd did this ). So, i have a proposition to add some informative printfs to if_bridge code, because returning "Invalid argument" is not so self explanatory, especially in the wrong MTU case. I think that most of the returns in bridge_ioctl_add(), could benefit from additional printf with more information. What do you think? --niki