From owner-svn-ports-head@FreeBSD.ORG  Wed Nov  6 08:56:27 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 11D93702; Wed,  6 Nov 2013 08:56:27 +0000 (UTC)
Date: Wed, 6 Nov 2013 08:56:27 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Ganael LAPLANCHE <martymac@FreeBSD.org>
Subject: Re: svn commit: r332954 - head/sysutils/fpart
Message-ID: <20131106085627.GC90001@FreeBSD.org>
References: <201311060814.rA68Ebi8077759@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201311060814.rA68Ebi8077759@svn.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Nov 2013 08:56:27 -0000

On Wed, Nov 06, 2013 at 08:14:37AM +0000, Ganael LAPLANCHE wrote:
> New Revision: 332954
> URL: http://svnweb.freebsd.org/changeset/ports/332954
> 
>  post-install:
>  .if ${PORT_OPTIONS:MDOCS}
> -	${MKDIR} ${DOCSDIR}
> +	${MKDIR} ${STAGEDIR}${DOCSDIR}
>  .for doc in ${PORTDOCS}
> -	${INSTALL_DATA} ${WRKSRC}/${doc} ${DOCSDIR}
> +	${INSTALL_DATA} ${WRKSRC}/${doc} ${STAGEDIR}${DOCSDIR}

In staging mode, it is no longer required to check for PORT_OPTIONS:MDOCS
(unless docs are actually being built via external dependency like Doxygen
or simply take way too much disk space).  Dropping the check would also
allow you to not include anything other than b.p.m.

You could have also got rid of ".for doc in ${PORTDOCS}" loop by using this
nice little trick:

    ${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${STAGEDIR}${DOCSDIR}

./danfe