From owner-freebsd-ports@freebsd.org Fri May 5 10:42:30 2017 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 69E5CD5F327 for ; Fri, 5 May 2017 10:42:30 +0000 (UTC) (envelope-from prvs=02986d7e46=ari@ish.com.au) Received: from fish.ish.com.au (ip-2.ish.com.au [203.29.62.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2A58ABB7 for ; Fri, 5 May 2017 10:42:29 +0000 (UTC) (envelope-from prvs=02986d7e46=ari@ish.com.au) Received: from [10.242.2.8] (port=49327 helo=Aristedess-MacBook-Pro.local) by fish.ish.com.au with esmtpsa (TLSv1.2:DHE-RSA-AES128-SHA:128) (Exim 4.82_1-5b7a7c0-XX) (envelope-from ) id 1d6agg-0001yQ-0S; Fri, 05 May 2017 20:42:14 +1000 X-CTCH-RefID: str=0001.0A150201.590C5706.0054, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 Subject: Re: diff and submissions To: Mathieu Arnold , Franco Fichtner Cc: FreeBSD Mailing List References: <750748ab-0e0e-cbb2-0b3b-d236829ee958@ish.com.au> <063dd680-2600-b440-b06b-04323eed6e58@FreeBSD.org> <22B42BD4-B348-49F6-8CF6-82B7B00E6B84@lastsummer.de> <05fd8f53-30b8-88fb-4d70-68637b2261b1@FreeBSD.org> From: Aristedes Maniatis Message-ID: <358b31bd-5f20-85d7-c172-2edf37c8c290@ish.com.au> Date: Fri, 5 May 2017 20:42:12 +1000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <05fd8f53-30b8-88fb-4d70-68637b2261b1@FreeBSD.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="7o8LILTnnUWT0jENAm93Hk6wVNDvD2C3n" X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 May 2017 10:42:30 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --7o8LILTnnUWT0jENAm93Hk6wVNDvD2C3n Content-Type: multipart/mixed; boundary="FVDjtr0bQ4e62SFbfJ5NtFauDge6XfRtU"; protected-headers="v1" From: Aristedes Maniatis To: Mathieu Arnold , Franco Fichtner Cc: FreeBSD Mailing List Message-ID: <358b31bd-5f20-85d7-c172-2edf37c8c290@ish.com.au> Subject: Re: diff and submissions References: <750748ab-0e0e-cbb2-0b3b-d236829ee958@ish.com.au> <063dd680-2600-b440-b06b-04323eed6e58@FreeBSD.org> <22B42BD4-B348-49F6-8CF6-82B7B00E6B84@lastsummer.de> <05fd8f53-30b8-88fb-4d70-68637b2261b1@FreeBSD.org> In-Reply-To: <05fd8f53-30b8-88fb-4d70-68637b2261b1@FreeBSD.org> --FVDjtr0bQ4e62SFbfJ5NtFauDge6XfRtU Content-Type: text/plain; charset=utf-8 Content-Language: en-AU Content-Transfer-Encoding: quoted-printable On 5/5/17 8:17pm, Mathieu Arnold wrote: > Le 05/05/2017 =C3=A0 08:16, Franco Fichtner a =C3=A9crit : >>> On 4. May 2017, at 10:20 AM, Mathieu Arnold wrote: >>> >>> If you went as far as being able to create a pull request, you can do= a >>> git show HEAD or git diff origin/trunk...HEAD and submit that in the >>> FreeBSD PR as well. >> It's pretty easy to extract the diff from a PR on GitHub, just append >> ".diff", and ".patch" works too, but gives the full git commit history= : >> >> https://github.com/freebsd/freebsd-ports/pull/62.diff >=20 > Yes, I am aware of that, the problem with github pull requests is that > they are outside of the FreeBSD bug report process, they do not get > assigned to maintainers, nobody notices them, they just stay there, and= > get obsolete. > There have been 61 before, yes, I closed a lot because they were > obsolete because it is outside of our process and nobody noticed them, > and for the rest either asked the submitter to open a PR on our > bugzilla, or opened one myself. >=20 A simple short term workaround might be: 1. Create a pull request template in github [1] 2. Include in it links to bugzilla and instructions for people to create = a parallel bug report with a link back to github The main reason I like github is that it is trivial to fork the repositor= y, copy in my patched port files and add comments to the commit. It is co= nsiderably more different to remember to create .orig files and then diff= them all, bundle it into a shar format and attach to bugzilla. This is all from the perspective of someone who makes a submission once e= very 3-6 months. Obviously if I had svn commit rights or had even checked= out the ports tree from svn then I'd have other options. Most people lik= e me use portsnap so they don't have an svn checkout. Cheers Ari [1] https://help.github.com/articles/creating-a-pull-request-template-for= -your-repository/ --=20 --------------------------> Aristedes Maniatis CEO, ish https://www.ish.com.au GPG fingerprint CBFB 84B4 738D 4E87 5E5C 5EFA EF6A 7D2E 3E49 102A --FVDjtr0bQ4e62SFbfJ5NtFauDge6XfRtU-- --7o8LILTnnUWT0jENAm93Hk6wVNDvD2C3n Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iEYEARECAAYFAlkMVwQACgkQ72p9Lj5JECp1YACdGLlDLDIC3rGuTdXSaIjUEAXA etQAn2HK+YbevXkYIw5PghIXKWpdL3fM =RBFm -----END PGP SIGNATURE----- --7o8LILTnnUWT0jENAm93Hk6wVNDvD2C3n--