From owner-svn-src-head@FreeBSD.ORG Wed Sep 16 21:28:15 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A70A1106568B for ; Wed, 16 Sep 2009 21:28:15 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id 03BD58FC19 for ; Wed, 16 Sep 2009 21:28:14 +0000 (UTC) Received: (qmail 2071 invoked by uid 399); 16 Sep 2009 21:28:12 -0000 Received: from localhost (HELO foreign.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 16 Sep 2009 21:28:12 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4AB15865.9030406@FreeBSD.org> Date: Wed, 16 Sep 2009 14:28:05 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 2.0.0.23 (X11/20090822) MIME-Version: 1.0 To: Ed Maste References: <200909141652.n8EGqdd1060471@svn.freebsd.org> In-Reply-To: <200909141652.n8EGqdd1060471@svn.freebsd.org> X-Enigmail-Version: 0.96.0 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, freebsd-rc@freebsd.org Subject: Re: svn commit: r197196 - head/etc/rc.d X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Sep 2009 21:28:15 -0000 I personally would much prefer that people making changes in rc.d-land be more careful about what they change and thoroughly test their changes than to add more code like this that will both hide breakage and become stale over time. Doug Ed Maste wrote: > Author: emaste > Date: Mon Sep 14 16:52:38 2009 > New Revision: 197196 > URL: http://svn.freebsd.org/changeset/base/197196 > > Log: > Protect cross-script invocation by checking that the target script exists. > This allows pruning of rc.d scripts without getting too many ugly boottime > error messages. > > Inspired by phk's r128714 change to netif. > > Modified: > head/etc/rc.d/ppp > > Modified: head/etc/rc.d/ppp > ============================================================================== > --- head/etc/rc.d/ppp Mon Sep 14 16:16:07 2009 (r197195) > +++ head/etc/rc.d/ppp Mon Sep 14 16:52:38 2009 (r197196) > @@ -95,8 +95,12 @@ ppp_poststart() > { > # Re-Sync ipfilter and pf so they pick up any new network interfaces > # > - /etc/rc.d/ipfilter quietresync > - /etc/rc.d/pf quietresync > + if [ -f /etc/rc.d/ipfilter ]; then > + /etc/rc.d/ipfilter quietresync > + fi > + if [ -f /etc/rc.d/pf ]; then > + /etc/rc.d/pf quietresync > + fi > } > > ppp_stop_profile() { > -- This .signature sanitized for your protection