From owner-freebsd-net@FreeBSD.ORG  Thu Feb  2 15:10:33 2012
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id DECCE106566C
	for <freebsd-net@freebsd.org>; Thu,  2 Feb 2012 15:10:33 +0000 (UTC)
	(envelope-from mjr@cs.wisc.edu)
Received: from sabe.cs.wisc.edu (sabe.cs.wisc.edu [128.105.6.20])
	by mx1.freebsd.org (Postfix) with ESMTP id 8D9658FC12
	for <freebsd-net@freebsd.org>; Thu,  2 Feb 2012 15:10:33 +0000 (UTC)
Received: from Core (71-90-102-157.dhcp.ftbg.wi.charter.com [71.90.102.157])
	(authenticated bits=0)
	by sabe.cs.wisc.edu (8.14.1/8.14.1) with ESMTP id q12EhH4w000673
	(version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO)
	for <freebsd-net@freebsd.org>; Thu, 2 Feb 2012 08:43:17 -0600
From: "Matt Renzelmann" <mjr@cs.wisc.edu>
To: <freebsd-net@freebsd.org>
Date: Thu, 2 Feb 2012 08:43:09 -0600
Message-ID: <003101cce1b8$fe7def80$fb79ce80$@cs.wisc.edu>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 14.0
Thread-Index: AczhuKfG3tvQ8A2kSBKOh7Nz7sn5WA==
Content-Language: en-us
Subject: 8139 driver question
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Feb 2012 15:10:33 -0000

Hello,

This will seem a bit off the wall, but I just noticed a discrepancy between the
registers defined in the pci/if_rlreg.h directory and those specified on the
RealTek datasheets for the antique RealTek 8139.

In particular, as defined in the header, the registers in question are:
#define RL_CFG0     0x0051      /* config register #0 */
#define RL_CFG1     0x0052      /* config register #1 */
#define RL_CFG2     0x0053      /* config register #2 */
#define RL_CFG3     0x0054      /* config register #3 */
#define RL_CFG4     0x0055      /* config register #4 */
#define RL_CFG5     0x0056      /* config register #5 */

The RealTek data sheets for the 8139, however, all indicate that these should be
set to something like this:
#define RL_CFG0     0x0051      /* config register #0 */
#define RL_CFG1     0x0052      /* config register #1 */
// No Config2
#define RL_CFG3     0x0059      /* config register #3 */
#define RL_CFG4     0x005A      /* config register #4 */
#define RL_CFG5     0x00D8      /* config register #5 */

The datasheets I'm referencing are available here:
http://realtek.info/pdf/

Specifically:
http://realtek.info/pdf/rtl8139d.pdf
http://realtek.info/pdf/rtl8139cp.pdf

I believe the registers currently used apply to the 8169, but not necessarily
the 8139 family -- can someone, hopefully easily, verify that the 8139 driver is
using the right registers?  The 8139 series may need the slightly different
values used above to enable functionality like wake-on-lan.

Thanks and regards,
Matt