From owner-cvs-all Wed May 17 8:21:56 2000 Delivered-To: cvs-all@freebsd.org Received: from gatekeeper.tsc.tdk.com (gatekeeper.tsc.tdk.com [207.113.159.21]) by hub.freebsd.org (Postfix) with ESMTP id 1FC3037BC41; Wed, 17 May 2000 08:21:50 -0700 (PDT) (envelope-from gdonl@tsc.tdk.com) Received: from imap.gv.tsc.tdk.com (imap.gv.tsc.tdk.com [192.168.241.198]) by gatekeeper.tsc.tdk.com (8.8.8/8.8.8) with ESMTP id IAA03420; Wed, 17 May 2000 08:21:45 -0700 (PDT) (envelope-from gdonl@tsc.tdk.com) Received: from salsa.gv.tsc.tdk.com (salsa.gv.tsc.tdk.com [192.168.241.194]) by imap.gv.tsc.tdk.com (8.9.3/8.9.3) with ESMTP id IAA26986; Wed, 17 May 2000 08:21:45 -0700 (PDT) (envelope-from Don.Lewis@tsc.tdk.com) Received: (from gdonl@localhost) by salsa.gv.tsc.tdk.com (8.8.5/8.8.5) id IAA29807; Wed, 17 May 2000 08:21:45 -0700 (PDT) From: Don Lewis Message-Id: <200005171521.IAA29807@salsa.gv.tsc.tdk.com> Date: Wed, 17 May 2000 08:21:44 -0700 In-Reply-To: <200005170405.VAA69180@freefall.freebsd.org> References: <200005170405.VAA69180@freefall.freebsd.org> X-Mailer: Mail User's Shell (7.2.6 beta(5) 10/07/98) To: Jonathan Lemon , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet ip_input.c Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On May 16, 9:05pm, Jonathan Lemon wrote: } Subject: cvs commit: src/sys/netinet ip_input.c } jlemon 2000/05/16 21:05:07 PDT } } Modified files: } sys/netinet ip_input.c } Log: } Cast sizeof() calls to be of type (int) when they appear in a signed } integer expression. Otherwise the sizeof() call will force the expression } to be evaluated as unsigned, which is not the intended behavior. Wouldn't (ssize_t) be more correct? I don't expect it to make any difference in this case, but on some architectures the size of a large object may not fit in an int. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message