Date: Fri, 04 Nov 2005 10:15:19 +0100 From: =?UTF-8?B?VsOhY2xhdiBIYWlzbWFu?= <V.Haisman@sh.cvut.cz> To: "M. Warner Losh" <imp@bsdimp.com> Cc: freebsd-hackers@freebsd.org Subject: Re: Kernel source hacking Message-ID: <436B26A7.2020104@sh.cvut.cz> In-Reply-To: <20051103.214104.62371333.imp@bsdimp.com> References: <436A7474.4040501@sh.cvut.cz> <20051103.214104.62371333.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] M. Warner Losh wrote: > In message: <436A7474.4040501@sh.cvut.cz> > Václav Haisman <V.Haisman@sh.cvut.cz> writes: > : I have noticed that there are still places in kernel sources that use > : K&R style of function parameter definitions. > > You must be looking at old sources. Most of the kernel has been I noticed that in version 1.651 of vfs_subr.c on MAIN branch through FreeBSD's CVSweb. > converted, but it is still a work in progress. There's very little > gain for the risk that something subtle that's different between K&R > and ANSI causes breakage... The risk is much lower these days since > we insist on proper prototypes... I think there is very little risk, with proper patch review. > > : Are the core developers interested in changing it into proper ANSI > : definitions? I would do it because it would give me a reason to read the > : code and learn something about the kernel. > > Nearly all of the kernel has been converted. The parts that remain > are the less widely travelled paths through the code. > > : Also, is there a page with other tasks for kernel neophytes like me? I > : looked for some such page but I couldn't find any. > > phk used to have a /jkh/ page, or Junior Kernel Hacker page. Don't > know if that's still that way or not. > > Warner Vaclav Haisman [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (MingW32) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iQEVAwUBQ2smrW56zbtzMDG0AQI9agf8CTtCii8ZUUkG1s9hFeioeDd+CoVMQQc2 axc7piQ/7bsLut0W6gpn/LvFgRu55pbtYotFuH/+4/4UDaUzcWA/NYmimsVS1LKd V0x2uA7PXqU2codtTB/nutcYobp1W+ejziWepwGi18JcAe0ATrXvNzL4Mdwlfasn 0vhkUqGuPyA4T9MvNcVPxBcGBhY0Q4Lj/zAN46VMj4hkO6IbdSkW/guiXFy7g6b/ EVPHSo+XOfWaMT/SAmPOWhDy5fWqckroWp+fNq1RSZwoH9YlG9OzCeKzMANZvBCF FowFE+PA8VVoH1N+qzio9ngrkn79ugQxSp/7QtKdtydERjV2A22GmQ== =dtj+ -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?436B26A7.2020104>