From owner-dev-commits-ports-main@freebsd.org Thu Apr 15 20:39:47 2021 Return-Path: Delivered-To: dev-commits-ports-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 19A275D6A54; Thu, 15 Apr 2021 20:39:47 +0000 (UTC) (envelope-from mpp302@gmail.com) Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FLrmz070Pz4pxh; Thu, 15 Apr 2021 20:39:46 +0000 (UTC) (envelope-from mpp302@gmail.com) Received: by mail-ed1-f53.google.com with SMTP id f8so29661027edd.11; Thu, 15 Apr 2021 13:39:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=RKknpKU+VPlFnOMgc6cGQ0jqHQ6BtdrdhrQ2w5Mp8KY=; b=h78VUoyzWFg9/3x/OkE5uEIvDgDbbxUgqgpK99mhliZXpP7A+XLESRX8Wjg7b4dTY7 JGmnRntusvV/HAFNgWNI8Oft18zF7bPkUUCtEWewKdeHovfzPZq5Vi1+F9C/gnVACejd khiUUTdAah7AUvz5Wd6J25PI3lp7Ld80gyzQPKVwbQVBYcrIy57DZzN4tGmSFVHImV3j oFAPfz2Lg4XjNn9oFh/9arqQayx+1seKNuLB8GLNCqc34jr+O0mY5YTinngBa6NHufMX wTeCtB8NT5DHU3iiY3/t7Lgt86gR5+QvlkcUX38odqr9MSqiAnpupvqXzjYOdy/oCyzr 32PQ== X-Gm-Message-State: AOAM530eMGD/OhmjqswY5v2Yzud1pjPsgaAvkI6MJ6jJiwzV+2oHmxhj WBgeZfgC3pW4ikLLA881ICSTLUxolqDt1A== X-Google-Smtp-Source: ABdhPJx1yPFZSOY7SYIX4BM4273Jrckn4Y97NEwYBmh1025qrVdJazrLC6od6TlfYFMLvvG2AbrJcg== X-Received: by 2002:a05:6402:2744:: with SMTP id z4mr6472767edd.347.1618519185198; Thu, 15 Apr 2021 13:39:45 -0700 (PDT) Received: from [192.168.0.106] (ip5f5bd493.dynamic.kabel-deutschland.de. [95.91.212.147]) by smtp.gmail.com with ESMTPSA id d6sm3458855edr.21.2021.04.15.13.39.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Apr 2021 13:39:44 -0700 (PDT) To: Guido Falsi , ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org References: <202104151800.13FI0R3i033069@gitrepo.freebsd.org> <5ce76d1a-ca79-6e84-376b-612805f317b6@FreeBSD.org> From: Mateusz Piotrowski <0mp@FreeBSD.org> Subject: Re: git: b3c7fff32af0 - main - sysutils/ansible-sshjail: New port Message-ID: Date: Thu, 15 Apr 2021 22:39:51 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <5ce76d1a-ca79-6e84-376b-612805f317b6@FreeBSD.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-Rspamd-Queue-Id: 4FLrmz070Pz4pxh X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-ports-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commits to the main branch of the FreeBSD ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Apr 2021 20:39:47 -0000 Hi, On 15/04/2021 21:46, Guido Falsi wrote: > On 15/04/21 21:07, Mateusz Piotrowski wrote: >> >>> diff --git a/sysutils/ansible-sshjail/Makefile b/sysutils/ansible-ssh= jail/Makefile >>> new file mode 100644 >>> index 000000000000..73499357b2f0 >>> --- /dev/null >>> +++ b/sysutils/ansible-sshjail/Makefile >>> @@ -0,0 +1,30 @@ >>> +PORTNAME=3D=C2=A0=C2=A0=C2=A0 ansible-sshjail >>> +DISTVERSION=3D=C2=A0=C2=A0=C2=A0 1.1.0-g20210107 >> [snip] >>> +GH_ACCOUNT=3D=C2=A0=C2=A0=C2=A0 austinhyde >>> +GH_TAGNAME=3D=C2=A0=C2=A0=C2=A0 981674f >> Perhaps GH_TAGNAME could be replaced with DISTVERSION* variables based=20 on the output of git=20 >> describe --tags which is "v1.1.0-30-g981674f". >> > > Is there a specific advantage to this approach? > > I did what I've been doing with other ports and also what I see documen= ted in the porter's handbook. > There are a couple of advantages: 1. There is only one block of variables you need to edit in case of an up= date. 2. DISTVERSION=3D1.1.0-30 becomes PORTVERSION=3D1.1.0.30. As a result, yo= u don't have to worry about=20 increasing the date manually. Also, if you happen to update the port twic= e to newer commit on a=20 single day, you don't have to come up with a workaround for 1.1.0-g202101= 07. The DISTVERSION will=20 just naturally increase from 1.1.0-30 to, e.g., 1.1.0-31. In fact, this is described in the FreeBSD Porter's Handbook in Example 5.= 14. Using USE_GITHUB to=20 Access a Commit Between Two Versions. The gYYYYMMDD is reserved for cases=20 when there is no single=20 version tagged by upstream (as explained in Example 5.13. Using USE_GITHU= B When Upstream Does Not=20 Use Versions). Cheers! Mateusz