From owner-freebsd-current@FreeBSD.ORG Mon Apr 5 20:20:54 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6B75F16A4CE for ; Mon, 5 Apr 2004 20:20:54 -0700 (PDT) Received: from carver.gumbysoft.com (carver.gumbysoft.com [66.220.23.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5CC7543D49 for ; Mon, 5 Apr 2004 20:20:54 -0700 (PDT) (envelope-from dwhite@gumbysoft.com) Received: by carver.gumbysoft.com (Postfix, from userid 1000) id 45E8872DCA; Mon, 5 Apr 2004 20:20:46 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by carver.gumbysoft.com (Postfix) with ESMTP id 406A072DBF; Mon, 5 Apr 2004 20:20:46 -0700 (PDT) Date: Mon, 5 Apr 2004 20:20:46 -0700 (PDT) From: Doug White To: Yuriy Tsibizov In-Reply-To: <20040404125622.S1846@free.home.local> Message-ID: <20040405201831.K82596@carver.gumbysoft.com> References: <20040404125622.S1846@free.home.local> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: freebsd-current@freebsd.org cc: Mathew Kanner Subject: Re: dev/sound/pcm/sound.h shadows INTR_MPSAFE declaration X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Apr 2004 03:20:54 -0000 On Sun, 4 Apr 2004, Yuriy Tsibizov wrote: > Today I've noticied that my driver is marked as Giant-locked: Is it actually MPSAFE? If so, feel free to mark it as such, although pcm isn't fully locked yet, so we take no responsibility for any damage caused :) > > -dmesg- > Copyright (c) 1992-2004 The FreeBSD Project. > Copyright (c) 1979, 1980, 1983, 1986, 1988, 1989, 1991, 1992, 1993, 1994 > The Regents of the University of California. All rights reserved. > FreeBSD 5.2-CURRENT #0: Sat Apr 3 11:57:58 MSD 2004 > chibis@free.home.local:/usr/obj/usr/src/sys/FREE-FAST > [..] > emu10kx0: port 0xd000-0xd01f irq 12 at device 10.0 on pci0 > emu10kx0: [GIANT-LOCKED] > -dmesg- > > because INTR_MPSAFE is defined to 0 in dev/sound/pcm/sound.h: > > -sound.h- > /* > [...] > * $FreeBSD: src/sys/dev/sound/pcm/sound.h,v 1.57 2004/03/06 15:52:42 matk Exp $ > */ > > [...] > > #ifndef INTR_MPSAFE > #define INTR_TYPE_AV INTR_TYPE_TTY > #endif > > #ifndef INTR_MPSAFE > #define INTR_MPSAFE 0 > #endif > -sound.h- > > and there is no macro INTR_MPSAFE defined inside kernel (it is defined in > enum). > > Yuriy Tsibizov, > http://chibis.persons.gfk.ru/audigy/ > > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" > -- Doug White | FreeBSD: The Power to Serve dwhite@gumbysoft.com | www.FreeBSD.org