Date: Sun, 19 Jun 2005 10:20:18 GMT From: Daniel Gerzo <danger@rulez.sk> To: freebsd-www@FreeBSD.org Subject: Re: www/82379: /cgi/query-pr.cgi has no submit button Message-ID: <200506191020.j5JAKICK021243@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR www/82379; it has been noted by GNATS. From: Daniel Gerzo <danger@rulez.sk> To: bug-followup@FreeBSD.org, ed@fxq.nl Cc: Subject: Re: www/82379: /cgi/query-pr.cgi has no submit button Date: Sun, 19 Jun 2005 12:19:11 +0200 --FCuugMFkClbJLl1L Content-Type: text/plain; charset=us-ascii Content-Disposition: inline This diff adds the submit button and it also cleans little bit html tags. -- Sincerely, DanGer, ICQ: 261701668 | e-mail protecting at: http://www.2pu.net/ http://danger.rulez.sk | proxy list at: http://www.proxy-web.com/ | FreeBSD - The Power to Serve! --FCuugMFkClbJLl1L Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="query-pr.cgi.diff" --- query-pr.cgi.orig Sun Jun 19 11:38:55 2005 +++ query-pr.cgi Sun Jun 19 12:03:32 2005 @@ -27,9 +27,10 @@ ($scriptname = $ENV{'SCRIPT_NAME'}) =~ s|^/?|/|; $scriptname =~ s|/$||; ($summary = $scriptname) =~ s/query-pr/query-pr-summary/; - print "<FORM METHOD=GET ACTION=\"$scriptname\">\n"; - print "<INPUT TYPE=TEXT NAME=pr></FORM>\n"; - print "<p>See also the <A HREF=\"$summary\">PR summary</A></p>\n"; + print "<form method='get' action='$scriptname'>\n"; + print "<input type='text' name='pr' /><br />\n"; + print "<input type='submit' value='Query' />\n</form>\n"; + print "<p>See also the <a href='$summary'>PR summary</a></p>\n"; print &html_footer; exit 0; } @@ -85,9 +86,9 @@ print &html_header("FreeBSD problem report"); if ($_ !~ /^query-pr(:?\.(:?real|web))?: no PRs matched$/) { print "<P>query-pr said:\n"; - print "<PRE>$_\n"; + print "<pre>$_\n"; print <Q>; - print "</PRE>\n"; + print "</pre>\n"; } else { print "<p>No PR found matching $pr\n"; } @@ -96,7 +97,7 @@ } elsif (/^lockf: /) { print &html_header("FreeBSD problem report"); print "<p>The PR database is currently busy; please try ", - "<A HREF=\"./query-pr.cgi?pr=$pr\">your query</A> again."; + "<a href='./query-pr.cgi?pr=$pr'>your query</a> again."; print &html_footer; exit; } @@ -142,7 +143,7 @@ $origsyn = $syn; $syn = &fixline($syn); print &short_html_header("Problem Report $cat/$number: $syn"); - print "<h1><font color=\"#660000\">Problem Report $cat/$number</font></h1>\n"; + print "<h1><font color='#660000'>Problem Report $cat/$number</font></h1>\n"; print "<strong>$syn</strong><p>\n<dl>\n"; } else { next if $inhdr; @@ -156,7 +157,7 @@ $trailer .= $2; } if ($1 eq "Originator" && $from ne "") { # add email address - $trailer .= " <<A HREF=\"mailto:$email\">" . &fixline($from) . "</A>>"; + $trailer .= " <<a href='mailto:$email'>" . &fixline($from) . "</a>>"; } $blank = !($2); $multiline = 0; @@ -180,7 +181,7 @@ $origsyn =~ s/[^a-zA-Z+.@-]/"%" . sprintf("%02X", unpack("C", $&))/eg; $email =~ s/[^a-zA-Z+.@-]/"%" . sprintf("%02X", unpack("C", $&))/eg; -print qq`<A HREF="mailto:bug-followup\@FreeBSD.org,${email}?subject=Re:%20${cat}/${number}:%20$origsyn">Submit Followup</A> | <A HREF="./query-pr.cgi?pr=$pr&f=raw">Raw PR</A>\n`; +print qq`<a href="mailto:bug-followup\@FreeBSD.org,${email}?subject=Re:%20${cat}/${number}:%20$origsyn">Submit Followup</a> | <a href="./query-pr.cgi?pr=$pr&f=raw">Raw PR</a>\n`; print &html_footer; @@ -228,12 +229,12 @@ local($href) = local($html) = $_; $href =~ s/&/%26/g; $html =~ s/&/&/g; - $_ = "<A HREF=\"$href\">$html</A>"; + $_ = "<a href='$href'>$html</a>"; } else { s/&/&/g; s/</</g; s/>/>/g; - s%(\WPR[:s# \t]+)([a-z3486]+\/)?([0-9]+)%$1<A HREF="query-pr.cgi?pr=$3">$2$3</A>%ig; + s%(\WPR[:s# \t]+)([a-z3486]+\/)?([0-9]+)%$1<a href="query-pr.cgi?pr=$3">$2$3</a>%ig; } $isurl = ! $isurl; } --FCuugMFkClbJLl1L--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200506191020.j5JAKICK021243>