From owner-freebsd-stable Mon Feb 5 14:38:59 2001 Delivered-To: freebsd-stable@freebsd.org Received: from level3.dynacom.net (level3.dynacom.net [206.107.213.213]) by hub.freebsd.org (Postfix) with SMTP id 3DD3E37B4EC for ; Mon, 5 Feb 2001 14:38:41 -0800 (PST) Received: (qmail 19114 invoked by uid 0); 5 Feb 2001 22:38:40 -0000 Received: from unknown (HELO urx.com) (206.159.132.160) by mail.urx.com with SMTP; 5 Feb 2001 22:38:40 -0000 Message-ID: <3A7F2B6F.4ED18797@urx.com> Date: Mon, 05 Feb 2001 14:38:39 -0800 From: Kent Stewart Reply-To: kstewart@urx.com Organization: Dynacom X-Mailer: Mozilla 4.76 [en] (Windows NT 5.0; U) X-Accept-Language: en MIME-Version: 1.0 To: Andrew Hesford Cc: freebsd-stable@freebsd.org Subject: Re: Problems with netgraph in today's 4.2-STABLE References: <20010205160412.A1535@cec.wustl.edu> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Andrew Hesford wrote: > > I tried building today's -STABLE kernel, and it failed while building > modules. There is a parse error in /usr/src/sys/netgear/ng_base.c, on > line 602, in the function ng_findname(). > > The error comes from having too many parentheses in the if condition in > the LIST_FOREACH block, as seen below: > > /* Find node by name */ > LIST_FOREACH(node, &nodelist, nodes) { > if (((node->name != NULL) > && (strcmp(node->name, name) == 0)) > && (node->flags & NG_INVALID) == 0)) > break; > > The last closing parenthesis in that block, "&& (node->flags & > NG_INVALID) == 0))", should be removed. This will allow compilation > without errors. Not really. That doesn't do what was intended. Re-cvsup. It has been fixed. Kent > > Happy building. > -- > Andrew Hesford - ajh3@chmod.ath.cx > "355/113 -- Not the famous irrational number PI, > but an incredible simulation!" > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-stable" in the body of the message -- Kent Stewart Richland, WA mailto:kbstew99@hotmail.com http://kstewart.urx.com/kstewart/index.html FreeBSD News http://daily.daemonnews.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message