From owner-freebsd-ports@FreeBSD.ORG Tue May 18 21:23:17 2004 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AE35D16A4CE for ; Tue, 18 May 2004 21:23:17 -0700 (PDT) Received: from mta7.pltn13.pbi.net (mta7.pltn13.pbi.net [64.164.98.8]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9F9AD43D39 for ; Tue, 18 May 2004 21:23:17 -0700 (PDT) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (6d932692674f088625c36e492abaa0a3@adsl-67-115-73-128.dsl.lsan03.pacbell.net [67.115.73.128]) by mta7.pltn13.pbi.net (8.12.10/8.12.10) with ESMTP id i4J4NEjU003202 for ; Tue, 18 May 2004 21:23:14 -0700 (PDT) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id E3EC554947; Tue, 18 May 2004 21:23:13 -0700 (PDT) Date: Tue, 18 May 2004 21:23:13 -0700 From: Kris Kennaway To: ports@FreeBSD.org Message-ID: <20040519042313.GB62080@xor.obsecurity.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="dDRMvlgZJXvWKvBx" Content-Disposition: inline User-Agent: Mutt/1.4.2.1i Subject: Wanted: Move fetch shell scripts out of bsd.port.mk X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 May 2004 04:23:17 -0000 --dDRMvlgZJXvWKvBx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline A large chunk of bsd.port.mk is taken up by various scripts that implement the fetching of distfiles and patchfiles. There are several permutations and available options (e.g. various kinds of sorting of MASTER_SITES), with yet more options waiting in PRs in GNATS, and all of it gets in the way of each other and of users trying to read bsd.port.mk. What I'd like to see is for the processing of distfile lists to be extracted out into external shell scripts, which users could select to choose a different sorting behaviour. For example, one way would be for bsd.port.mk to feed the value of MASTER_SITES to the script, which returns with its sorted version of the same list for bsd.port.mk to fetch from. I don't know if there's a need for the fetching itself to be done externally (you can already specify your own external program to do the fetching), as this code will probably be common to every script. This will simplify bsd.port.mk, simplify the fetching logic (don't have one massive target trying to implement all the alternative sorting behaviours) and simplify the shell scripts themselves (as they don't have to have most of their metacharacters escaped). Any takers? Kris --dDRMvlgZJXvWKvBx Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAquExWry0BWjoQKURAgOWAJ9ltcJxbnM6VT2LLeF6myJVlk6y4wCg+aXo 8yuGUbMGX7PAxsna/IOUGpY= =DR5H -----END PGP SIGNATURE----- --dDRMvlgZJXvWKvBx--