From owner-svn-src-head@FreeBSD.ORG  Sun Mar  7 10:43:03 2010
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B0685106566C;
	Sun,  7 Mar 2010 10:43:03 +0000 (UTC)
	(envelope-from alexander@leidinger.net)
Received: from mail.ebusiness-leidinger.de (mail.ebusiness-leidinger.de
	[217.11.53.44])
	by mx1.freebsd.org (Postfix) with ESMTP id 5C6688FC15;
	Sun,  7 Mar 2010 10:43:03 +0000 (UTC)
Received: from outgoing.leidinger.net (pD954FC7A.dip.t-dialin.net
	[217.84.252.122])
	by mail.ebusiness-leidinger.de (Postfix) with ESMTPSA id 9589C844956;
	Sun,  7 Mar 2010 11:42:58 +0100 (CET)
Received: from unknown (unknown [192.168.2.110])
	by outgoing.leidinger.net (Postfix) with ESMTP id D72E850F1;
	Sun,  7 Mar 2010 11:42:55 +0100 (CET)
Date: Sun, 7 Mar 2010 11:42:54 +0100
From: Alexander Leidinger <Alexander@Leidinger.net>
To: Doug Barton <dougb@FreeBSD.org>
Message-ID: <20100307114254.00004897@unknown>
In-Reply-To: <4B92AFE7.4040200@FreeBSD.org>
References: <201003051434.o25EYXBR024375@svn.freebsd.org>
	<alpine.BSF.2.00.1003052113350.98935@serrsnyy.serrofq.bet>
	<20100306162535.000078b8@unknown> <4B92AFE7.4040200@FreeBSD.org>
X-Mailer: Claws Mail 3.7.2cvs15 (GTK+ 2.16.0; i586-pc-mingw32msvc)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-EBL-MailScanner-Information: Please contact the ISP for more information
X-EBL-MailScanner-ID: 9589C844956.00CAC
X-EBL-MailScanner: Found to be clean
X-EBL-MailScanner-SpamCheck: not spam, spamhaus-ZEN,
	SpamAssassin (not cached, score=-1.363, required 6,
	autolearn=disabled, ALL_TRUSTED -1.44, TW_SV 0.08)
X-EBL-MailScanner-From: alexander@leidinger.net
X-EBL-MailScanner-Watermark: 1268563379.55125@O6ZbCxYqziMp1vdolnfrRw
X-EBL-Spam-Status: No
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r204759 - in head: etc/defaults etc/rc.d
 share/man/man5
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 07 Mar 2010 10:43:03 -0000

On Sat, 06 Mar 2010 11:41:27 -0800 Doug Barton <dougb@FreeBSD.org>
wrote:

> On 3/6/2010 7:25 AM, Alexander Leidinger wrote:

> > The trick with command_args is neat, but it is a pitfall in case
> > someone wants to use it in the future. Wouldn't it be better to add
> > the ampersand to it instead of letting the ampersand replace the
> > value?
> 
> Yes, obviously if someone wants to use command_args for an additional 
> purpose down the road changes will have to be made. It's not in use
> atm however, so IMO simpler is better.

In general I agree to KISS, but the change now would be
  command_args="${command_args}&"
which is not complex at all and is safer for the future.

Bye,
Alexander.