From owner-freebsd-ports@freebsd.org Fri Mar 18 23:41:58 2016 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D7490AD538E for ; Fri, 18 Mar 2016 23:41:58 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id C7B0DA24 for ; Fri, 18 Mar 2016 23:41:58 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: by mailman.ysv.freebsd.org (Postfix) id C6E7BAD538D; Fri, 18 Mar 2016 23:41:58 +0000 (UTC) Delivered-To: ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C68ADAD538C for ; Fri, 18 Mar 2016 23:41:58 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: from gw.catspoiler.org (unknown [IPv6:2602:304:b010:ef20::f2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "gw.catspoiler.org", Issuer "gw.catspoiler.org" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id A631DA22 for ; Fri, 18 Mar 2016 23:41:58 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2]) by gw.catspoiler.org (8.15.2/8.15.2) with ESMTP id u2INfnxY047518; Fri, 18 Mar 2016 16:41:53 -0700 (PDT) (envelope-from truckman@FreeBSD.org) Message-Id: <201603182341.u2INfnxY047518@gw.catspoiler.org> Date: Fri, 18 Mar 2016 16:41:49 -0700 (PDT) From: Don Lewis Subject: Re: gnome-post-install ordering To: henry.hu.sh@gmail.com cc: ports@freebsd.org In-Reply-To: MIME-Version: 1.0 Content-Type: TEXT/plain; charset=us-ascii X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Mar 2016 23:41:58 -0000 On 17 Mar, Henry Hu wrote: > On Wed, Mar 16, 2016 at 1:57 PM, Don Lewis wrote: > >> I'm trying to debug why gtk-update-icon-cache isn't getting run when >> the OpenOffice package is installed and ran into something that I don't >> understand. >> >> The Makefile contains INSTALLS_ICONS=yes, which has the side effect of >> setting USES+=gnome, USE_GNOME+=gtk-update-icon-cache, and >> _USES_install+=690:gnome-post-install, and that target is responsible >> for parsing ${TMPPLIST} and invoking gtk-update-icon-cache as needed. >> I do see gtk-update-icon-cache in the dependency list in +MANIFEST, so >> it appears that INSTALLS_ICONS=yes is being detected. >> >> It appears that things go wrong because I'm using the Makefile >> post-install target to generate the plist. If I look at bsd.port.mk, I >> see that _STAGE_SEQ contains 700:post-install. It looks to me like >> gnome-post-install is getting run before the plist is generated, which >> would explain why gnome-post-install isn't detecting any icons and not >> invoking gtk-update-icon-cache. >> >> Why is gnome-post-install earlier than post-install, which at least some >> ports use to do plist generation? Some ports do plist generation in >> do-install, but that doesn't work if there are do-install option helpers >> because those get run after the main do-install target. >> > > It looks smilar to the issue I mentioned in PR 206019. It's also caused by > generated plist, but in that case it is a python port. It's a related problem. In this case, the plist is getting created by 940:add-plist-post, which happens a lot later than post-install.