From owner-freebsd-hackers@FreeBSD.ORG  Sun Jan 27 02:07:21 2008
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 14BF216A41A
	for <hackers@freebsd.org>; Sun, 27 Jan 2008 02:07:21 +0000 (UTC)
	(envelope-from cristi@roedu.net)
Received: from alpha.roedu.net (alpha.roedu.net [81.180.250.131])
	by mx1.freebsd.org (Postfix) with ESMTP id A542213C468
	for <hackers@freebsd.org>; Sun, 27 Jan 2008 02:07:20 +0000 (UTC)
	(envelope-from cristi@roedu.net)
Received: from localhost (localhost [127.0.0.1])
	by alpha.roedu.net (Postfix) with ESMTP id DFEF69B2F8;
	Sun, 27 Jan 2008 04:07:08 +0200 (EET)
X-Virus-Scanned: amavisd-new at roedu.net
Received: from alpha.roedu.net ([127.0.0.1])
	by localhost (alpha.roedu.net [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 3QZG7ePc0zjV; Sun, 27 Jan 2008 04:07:07 +0200 (EET)
Received: from [172.27.2.200] (c7.campus.utcluj.ro [193.226.6.226])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client did not present a certificate)
	by alpha.roedu.net (Postfix) with ESMTP id 99B619B2E0;
	Sun, 27 Jan 2008 04:07:07 +0200 (EET)
Message-ID: <479BE74D.50507@roedu.net>
Date: Sun, 27 Jan 2008 04:07:09 +0200
From: Cristian KLEIN <cristi@roedu.net>
User-Agent: Thunderbird 2.0.0.6 (X11/20071022)
MIME-Version: 1.0
To: Doug Barton <dougb@FreeBSD.org>
References: <50587.193.226.5.33.1201086363.squirrel@mail.roedu.net>
	<20080123202543.GA59457@keira.kiwi-computer.com>
	<alpine.BSF.1.00.0801261619240.16534@ync.qbhto.arg>
In-Reply-To: <alpine.BSF.1.00.0801261619240.16534@ync.qbhto.arg>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "Rick C. Petty" <rick-freebsd@kiwi-computer.com>, hackers@freebsd.org
Subject: Re: DIST_SUBDIR not working with MASTER_SITE_OVERRIDE
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 27 Jan 2008 02:07:21 -0000

Doug Barton a scris:
> On Wed, 23 Jan 2008, Rick C. Petty wrote:
> 
>> On Wed, Jan 23, 2008 at 01:06:03PM +0200, cristi@roedu.net wrote:
>>> Hi everybody,
>>>
>>> I recently wanted to install some gnome stuff from ports. In order to
>>> boost the download speed, I did something like this:
>>>
>>>  make 
>>> MASTER_SITE_OVERRIDE=ftp://ftp1.ro.freebsd.org/pub/FreeBSD/distfiles/
>>>
>>> as documented in the Handbook. However, many gnome packages seem to have
>>> DIST_SUBDIR in their Makefile, but MASTER_SITE_OVERRIDE doesn't care. 
>>> This
>>> makes installing ports (with many dependencies) from known non-default
>>> sources very hard.
>>
>> I used to do something similar to this by setting it in /etc/make.conf.
>> The only downside is if DIST_SUBDIR is not set you get paths that don't
>> look pretty, e.g.:
>>     ftp://ftp5.freebsd.org/pub/FreeBSD/distfiles//some_distfile.tgz
>>
>> Instead, I added something to my /etc/make.conf similar to:
>>
>> .if defined(DIST_SUBDIR)
>> DIST_SUBDIR_OVERRIDE=${DIST_SUBDIR}/
>> .else
>> DIST_SUBDIR_OVERRIDE=
>> .endif
>> MASTER_SITE_OVERRIDE=ftp://ftp5.freebsd.org/pub/FreeBSD/distfiles/${DIST_SUBDIR_OVERRIDE} 
>>
> 
> IMO it would be a lot more intuitive if the ports infrastructure did 
> exactly this for the user.

Perhaps there should be two variables:
MASTER_SITE_OVERRIDE and MASTER_SITE_OVERRIDE_ALL.