From owner-svn-src-head@FreeBSD.ORG Mon Jul 21 17:48:38 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0B59D770; Mon, 21 Jul 2014 17:48:38 +0000 (UTC) Received: from forward18.mail.yandex.net (forward18.mail.yandex.net [IPv6:2a02:6b8:0:1402::3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "forwards.mail.yandex.net", Issuer "Certum Level IV CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7A79B213D; Mon, 21 Jul 2014 17:48:37 +0000 (UTC) Received: from web23g.yandex.ru (web23g.yandex.ru [95.108.253.232]) by forward18.mail.yandex.net (Yandex) with ESMTP id D467D1781B5E; Mon, 21 Jul 2014 21:48:32 +0400 (MSK) Received: from 127.0.0.1 (localhost [127.0.0.1]) by web23g.yandex.ru (Yandex) with ESMTP id 3C0443200153; Mon, 21 Jul 2014 21:48:32 +0400 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1405964912; bh=eNuiDgR3NBN0R5V5LWjkwwpfsE79R9s3lGG0KmmIvm0=; h=From:To:Cc:In-Reply-To:References:Subject:Date; b=SbgdtD8C4GGYk1bS2E1+D8VCW150eeQEvVsSkJn0oHM1wdOfVDb02iL0KuIIJ0Xht AMsAEqpV+4BE5geepxE7upi8g3J1u4lyjefwhgVmBDd+7CH3jlZ5Nj1qvAdayhM3Sw dfqOMoFwJIlv6+LDZ7b5gLTRRP1PuO1sz19HvFYk= Received: from m1cro.park.rambler.ru (m1cro.park.rambler.ru [81.19.64.111]) by web23g.yandex.ru with HTTP; Mon, 21 Jul 2014 21:48:31 +0400 From: Ilya A. Arkhipov Envelope-From: rum1cro@yandex.ru To: Nikolai Lifanov , Steven Hartland In-Reply-To: <1048c8cc25685b1216b0f1714c4494f1@mail.lifanov.com> References: <201407182041.s6IKffMR077972@svn.freebsd.org> <5d0810f5950150ef60044acf239adb4a@mail.lifanov.com> <09AF6051EC3848B6B691A5570B5B065E@multiplay.co.uk> <1048c8cc25685b1216b0f1714c4494f1@mail.lifanov.com> Subject: Re: svn commit: r268855 - in head: cddl/contrib/opensolaris/cmd/ztest sys/cddl/contrib/opensolaris/uts/common/fs/zfs sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys MIME-Version: 1.0 Message-Id: <9780681405964911@web23g.yandex.ru> X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Mon, 21 Jul 2014 21:48:31 +0400 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=koi8-r Cc: "svn-src-head@freebsd.org" , Xin LI X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2014 17:48:38 -0000 21.07.2014, 07:50, "Nikolai Lifanov" : > On 2014-07-20 22:56, Steven Hartland wrote: >> š----- Original Message ----- From: "Nikolai Lifanov" >> š >> šTo: "Xin LI" >> šCc: ; >> šSent: Monday, July 21, 2014 2:22 AM >> šSubject: Re: svn commit: r268855 - in head: >> šcddl/contrib/opensolaris/cmd/ztest >> šsys/cddl/contrib/opensolaris/uts/common/fs/zfs >> šsys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys >>> šOn 2014-07-18 16:41, Xin LI wrote: >>>> šAuthor: delphij >>>> šDate: Fri Jul 18 20:41:40 2014 >>>> šNew Revision: 268855 >>>> šURL: http://svnweb.freebsd.org/changeset/base/268855 >>>> >>>> šLog: >>>> šššMFV r268848: >>>> >>>> šššInstead of asserting all zio's be properly aligned, only assert >>>> šššon the logical ones. >>>> >>>> šššCap uberblocks at 8k, otherwise with ashift=17, there would be >>>> šššonly one uberblock. >>>> >>>> šššThis fixes a problem that zdb would trip assert on pools with >>>> šššashift >= 0xe (8k). >>>> >>>> šššWhile there, also change the code so it only attempt to condense >>>> šššspace map unless the uncondensed size consumes greater than >>>> šššzfs_metaslab_condense_block_threshold blocks. >>>> >>>> šššIllumos issue: >>>> ššššš4958 zdb trips assert on pools with ashift >= 0xe >>>> >>>> šššMFC after: 2 weeks >>> šThis specific commit makes boot hang just before mounting the root >>> šdataset for me when vfs.zfs.vdev.cache.size tunable is set. Unsetting >>> šthis tunable or reverting this commit (currently running r268933 minus >>> šr268855) fixes the boot for me. >>> >>> šPlease let me know if I can provide any more information. >> šInteresting, is there a reason you enabled vdev caching as its been >> šdisabled by default for quite some time with the comment: >> >> š* TODO: Note that with the current ZFS code, it turns out that the >> š* vdev cache is not helpful, and in some cases actually harmful. šIt >> š* is better if we disable this. šOnce some time has passed, we should >> š* actually remove this to simplify the code. šFor now we just disable >> š* it by setting the zfs_vdev_cache_size to zero. šNote that Solaris 11 >> š* has made these same changes. >> >> ššššRegards >> ššššSteve >> >> š_______________________________________________ >> šsvn-src-head@freebsd.org mailing list >> šhttp://lists.freebsd.org/mailman/listinfo/svn-src-head >> šTo unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" > > I noticed that it was disabled on default and I'm not seeing any ill > effect now that I have it disabled. I don't find vdev cache beneficial, > but I had it in my loader.conf for some time, and I had to remove it to > get the system to boot. If it's going to be broken going forward, > perhaps it's worthwhile to just remove the tunable? > > - Nikolai Lifanov > _______________________________________________ > svn-src-head@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" Hi All, Looks like I got error related with this commit. Before loading kernel(after installworld) I get error with "zfs unsupported ..."(can't get full error message so fast have reboot) Trying upgrade r256311 to r268939(loading from pxe and rollback solve this problem ^_^). Some one have the same issue? -- With Best Regards, Ilya A. Arkhipov