From owner-freebsd-gnome@freebsd.org Sat Jul 23 16:51:10 2016 Return-Path: Delivered-To: freebsd-gnome@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5AE39BA2BB9 for ; Sat, 23 Jul 2016 16:51:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 4413B1F27 for ; Sat, 23 Jul 2016 16:51:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 3FEBDBA2BB8; Sat, 23 Jul 2016 16:51:10 +0000 (UTC) Delivered-To: gnome@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3D4BABA2BB7 for ; Sat, 23 Jul 2016 16:51:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1F37A1F26 for ; Sat, 23 Jul 2016 16:51:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u6NGp91C006249 for ; Sat, 23 Jul 2016 16:51:09 GMT (envelope-from bugzilla-noreply@freebsd.org) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" From: bugzilla-noreply@freebsd.org To: gnome@FreeBSD.org Subject: maintainer-approval requested: [Bug 211201] print/freetype2: update to 2.6.5, replace LCD_FILTERING with V40 code : [Attachment 172900] Proposed patch (since 412348 revision) Date: Sat, 23 Jul 2016 16:51:09 +0000 X-Bugzilla-Type: request X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-qa, patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: gnome@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Jul 2016 16:51:10 -0000 lightside has asked gnome@FreeBSD.org for maintainer-approval: Bug 211201: print/freetype2: update to 2.6.5, replace LCD_FILTERING with V40 code https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D211201 Attachment 172900: Proposed patch (since 412348 revision) https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D172900&action=3Dedit --- Comment #25 from lightside --- Created attachment 172900 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D172900&action= =3Dedit Proposed patch (since 412348 revision) (In reply to comment #23) > SUBPIXEL_HINTING_MODE is unnecessary distraction in your case. > The variable can still be kept for bmake simplification. Looks like, I was right about OPTIONS_RADIO instead of OPTIONS_GROUP. I ren= amed BOTH option to V38_V40. The (1 | 2) =3D 3, by the way. If you not agree, better to propose your version, I think. It may be usable= in case of 3 or more such modes (excluding overall mode). (In reply to comment #24) > freetype2 is mainly configured via fontconfig, not via environment variab= les. > With V38 and V40 both OFF by default CONFIGURABLE maybe of debugging value only. Ok, I removed CONFIGURABLE option. Thanks for reviews.