From nobody Fri Sep 29 12:45:26 2023 X-Original-To: wireless@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Rxqng0NZ2z4tsDH for ; Fri, 29 Sep 2023 12:45:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Rxqnf5mbGz3WB3 for ; Fri, 29 Sep 2023 12:45:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1695991526; a=rsa-sha256; cv=none; b=nTq6gDup5laoW91OcK5LwtZQS3TnqoW4FL9z7QnyTvcObNim2ZNJYJ66PFOZNPG4HS8kx5 EKcXlklj09o2MbwFpUQsdV9djB+8ETXExIz7GvHmawtv0feKLJXLizzCXK6PV2EUfgG0qG jEcCZi+MnKP7Nsduq1VayE6KYAvQ+fJmflHXnAM6H69qPYyOW5V3ipaBuehUeZpCCvsvg8 ETvzxy0zn74BpnUIZXpOIb28OrGUMhhL2DljtGKdHd9EMLDSthsHUIO//minIdWdx5E7oi dXupRAhBufumlXme/4ZWAY7K+I15XWryyLrVc1HhibnWkIUPoTbsFYjOQFS3rw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695991526; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3Ax656ilzcJBHAcQ4v1Ylg6xpkrYusiI3U6s/80+REU=; b=JEikZ7sZOSg2xrTzHxqZ5bVpfoU0epU9jKSLcj7ZRxJymRhet2KQJGYr2WFcHLACr8OFY0 xYbZ6BlPIPPIiW2olhtLGYqPxKJmwxqm4l2PWR1nLoNR2MoXpOXfXk8mWfghLohpr04NVD 8H9m4YaSbVCp7zyHzwacMj2jtX3WEgv3q1307fUD/22nzwTDI6ZXyqcTxrNsU0V3NwXMGG V3ezYFnBwUV7ATnHay3hIhgCI5YCzAgX8f0A5smYkHAwmw+qAYVM4j4x7rp3Dkm1e6FlhG IfXaivOURo7URmQM8opCajAvmSaTE1mc0usJBwTJlVWBmbc7Tgz8mgcTfEHi3A== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Rxqnf4qWBz13xK for ; Fri, 29 Sep 2023 12:45:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 38TCjQID000998 for ; Fri, 29 Sep 2023 12:45:26 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 38TCjQr4000997 for wireless@FreeBSD.org; Fri, 29 Sep 2023 12:45:26 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: wireless@FreeBSD.org Subject: [Bug 274156] ic->ic_vhtcaps check in ieee80211_setupcurchan Date: Fri, 29 Sep 2023 12:45:26 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: wireless X-Bugzilla-Version: 13.2-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: misha@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: wireless@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussions List-Archive: https://lists.freebsd.org/archives/freebsd-wireless List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-wireless@freebsd.org X-BeenThere: freebsd-wireless@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D274156 Bug ID: 274156 Summary: ic->ic_vhtcaps check in ieee80211_setupcurchan Product: Base System Version: 13.2-RELEASE Hardware: amd64 OS: Any Status: New Severity: Affects Only Me Priority: --- Component: wireless Assignee: wireless@FreeBSD.org Reporter: misha@freebsd.org https://github.com/freebsd/freebsd-src/blob/main/sys/net80211/ieee80211_nod= e.c#L807 this code checks ic->ic_vhtcaps and proceeds only if it's non-zero, but I wasn't able to find any mandatory non-zero vht caps, which must be always present, IEEE80211_VHTCAP_MAX_MPDU_LENGTH_3895, which is the "default" is z= ero itself and doesn't influence the variable this means that if a driver doesn't set the variable to at least something non-zero (for example non-default ampdu) - it will never get connected with 11ac, although it can be capable of doing it code snippet: /* * VHT promotion - this will at least promote to VHT20/40 * based on what HT has done; it may further promote the * channel to VHT80 or above. */ if (ic->ic_vhtcaps !=3D 0) { int flags =3D getvhtadjustflags(ic); if (flags > ieee80211_vhtchanflags(c)) c =3D ieee80211_vht_adjust_channel(ic, c, flags); } --=20 You are receiving this mail because: You are the assignee for the bug.=