From owner-freebsd-ports-bugs@FreeBSD.ORG Sun May 18 15:50:01 2014 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7CE698DD for ; Sun, 18 May 2014 15:50:01 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4EF4D2459 for ; Sun, 18 May 2014 15:50:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.8/8.14.8) with ESMTP id s4IFo0e8027368 for ; Sun, 18 May 2014 15:50:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s4IFo0ME027349; Sun, 18 May 2014 15:50:00 GMT (envelope-from gnats) Date: Sun, 18 May 2014 15:50:00 GMT Message-Id: <201405181550.s4IFo0ME027349@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org Cc: From: Zsolt Udvari Subject: Re: ports/189777: [patch] www/codeigniter staging, change url Reply-To: Zsolt Udvari X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 May 2014 15:50:01 -0000 The following reply was made to PR ports/189777; it has been noted by GNATS. From: Zsolt Udvari To: Guido Falsi Cc: bug-followup@freebsd.org, appleboy.tw@gmail.com Subject: Re: ports/189777: [patch] www/codeigniter staging, change url Date: Sun, 18 May 2014 17:43:35 +0200 To maintainer: do you think files/codeigniter-*.conf.in are needed? I think it's enough to ship a sample apache configuration file (if build with APACHE support) and show a simple message with an attention to check, configure and restart webserver (apache, lighttpd, nginx, etc.). I think the "PROD" option should drop - the developer can configure his/her webserver. And this option is useful _only_ with Apache - doesn't include any lighttpd/nginx config. And I think the PHP_CGI check is unnecessary too because of it's Apache-specific. Summary (of my thinks): - drop PROD option (and "confighelp" target too) - drop PHP_CGI check and cgi-specific message - drop apache configuration files, except a simple one (or maybe can install apache config file into codeigniter's doc/examplesdir without any APACHE-option) - drop any option-specific message - message content is: attention about check/config/reload webserver, create a correct index.php from index.php.sample (I think shouldn't create index.php because it's modified because of database settings - but I think nobody use this index.php, for example I'm copying it into my ~/public_html/app and modify this copied version). Maybe a simple plus message about production/develop installation (point to codeigniter/user_guide/installation/index.html) With this changes the port will be more simplier. If you think these changes are correct I'll create a patch. Zsolt 2014-05-14 22:51 GMT+02:00 Guido Falsi : > While looking at this patch I noticed it has a problem. > > The staging conversion is incomplete. > > The port is still echoing pkg-message by itself, which is unnecessary > with staging. > > The port also echoes various user message during installation, this is > wrong when using staging, since thee messages will appear at the wrong > time, and will never be seen by people using binary packages. > > Such messages should be moved to the pkg-message, or, is conditionally > shown, a pkg-install script should be created to show them if necessary. > > Can this patch be fixed keeping all this in mind? > > The port is also redefining WWWDIR to it's default value, why is this > needed? > > Thanks in advance. > > -- > Guido Falsi