From owner-svn-src-all@freebsd.org Wed Sep 2 18:28:16 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8E7C63C41A7; Wed, 2 Sep 2020 18:28:16 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BhXW43FkHz41Dy; Wed, 2 Sep 2020 18:28:16 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from [192.168.0.5] (unknown [181.52.72.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: pfg) by smtp.freebsd.org (Postfix) with ESMTPSA id A806C25DB2; Wed, 2 Sep 2020 18:28:15 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Subject: Re: svn commit: r365071 - in head/sys: net net/altq net/route net80211 netgraph netgraph/atm netgraph/atm/ccatm netgraph/atm/sscfu netgraph/atm/sscop netgraph/atm/uni netgraph/bluetooth/common netgraph... To: Alexey Dokuchaev Cc: Michael Tuexen , Mateusz Guzik , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <202009012119.081LJERb018106@repo.freebsd.org> <95844C00-D10A-456D-AD29-DF572043074F@fh-muenster.de> <20200902020507.GA38274@FreeBSD.org> <20200902180626.GA88595@FreeBSD.org> From: Pedro Giffuni Organization: FreeBSD Message-ID: <6124a908-25a5-e023-16da-7963ba229b7f@FreeBSD.org> Date: Wed, 2 Sep 2020 13:28:14 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200902180626.GA88595@FreeBSD.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Sep 2020 18:28:16 -0000 On 02/09/2020 13:06, Alexey Dokuchaev wrote: > On Wed, Sep 02, 2020 at 10:18:15AM -0500, Pedro Giffuni wrote: >> On 01/09/2020 21:05, Alexey Dokuchaev wrote: >>> ... >>> This is common sense. I can't count how often I wanted to hack on >>> something in the base/kernel and was turned away by this atrocious >>> excessive whitespace mess. >>> >>> Thank you Mateusz for cleaning this up. >> I honestly don't care much, but spaces do no harm and can make the code >> more readable. Sort of a silent comment, or what you do in written >> language when you start a new paragraph. > Right, but that's the example of appropriate usage of whitespace. I was > talking about *excessive* whitespace, that is, more than two \n's in a row > if we speak of newlines (subject of these commits). But how much space is rather subjective so Michael is right in asking what rule has been violated. No one is asking for the change to be reverted: the damage, if any, is already done. Pedro. > ./danfe