From owner-svn-src-head@freebsd.org  Sun Nov  5 19:02:20 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 64E20E4E5D1;
 Sun,  5 Nov 2017 19:02:20 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id E9BFF65C6D;
 Sun,  5 Nov 2017 19:02:19 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from tom.home (kib@localhost [127.0.0.1])
 by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id vA5J2EJ0073428
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Sun, 5 Nov 2017 21:02:14 +0200 (EET)
 (envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua vA5J2EJ0073428
Received: (from kostik@localhost)
 by tom.home (8.15.2/8.15.2/Submit) id vA5J2EId073427;
 Sun, 5 Nov 2017 21:02:14 +0200 (EET)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
 using -f
Date: Sun, 5 Nov 2017 21:02:14 +0200
From: Konstantin Belousov <kostikbel@gmail.com>
To: Warner Losh <imp@bsdimp.com>
Cc: "Conrad E. Meyer" <cem@freebsd.org>,
 src-committers <src-committers@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Subject: Re: svn commit: r325386 - head/sys/kern
Message-ID: <20171105190214.GG2566@kib.kiev.ua>
References: <201711041049.vA4AnZUE096709@repo.freebsd.org>
 <CAG6CVpUaXSX26Bc839kn96EXnUjtGyQ3_eNJPhsRB+v6G6gH1Q@mail.gmail.com>
 <20171105130607.GA2566@kib.kiev.ua>
 <CAG6CVpV3SfV8VuNeMJEuN+MSu3424mK=HO_-YW9vRt9HEdcJZQ@mail.gmail.com>
 <20171105173032.GE2566@kib.kiev.ua>
 <CAG6CVpVQ4RSgz883ezsdExVDQ4RbSiR_y+Z5XWDNFeYBpMS-cQ@mail.gmail.com>
 <CANCZdfqApxd99G-HqVfe4x8EysYJVCAcHksqTeUuBAaYR1OjEA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CANCZdfqApxd99G-HqVfe4x8EysYJVCAcHksqTeUuBAaYR1OjEA@mail.gmail.com>
User-Agent: Mutt/1.9.1 (2017-09-22)
X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no
 autolearn_force=no version=3.4.1
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 05 Nov 2017 19:02:20 -0000

On Sun, Nov 05, 2017 at 11:42:51AM -0700, Warner Losh wrote:
> On Sun, Nov 5, 2017 at 11:32 AM, Conrad Meyer <cem@freebsd.org> wrote:
> 
> > E.g.,
> >
> > --- a/sys/ufs/ffs/ffs_alloc.c
> > +++ b/sys/ufs/ffs/ffs_alloc.c
> > @@ -304,8 +304,7 @@ retry:
> >         }
> >
> >         if (bp->b_blkno == bp->b_lblkno) {
> > -               if (lbprev >= UFS_NDADDR)
> > -                       panic("ffs_realloccg: lbprev out of range");
> > +               ASSERT(lbprev < UFS_NDADDR, "ffs_realloccg: lbprev out
> > of range");
> >                 bp->b_blkno = fsbtodb(fs, bprev);
> >         }
> >
> 
> Just a side point: All these should be programming errors. The bogus data
> that comes or could come from the FS itself should remain always-on panics.
> Well, actually, they should transition from always-on panics to some sort
> of degraded mount that would be more resilient in the face of such
> corruption. But failing that, they should remain always-on panics :)

This is what I said in my reply before the last.

I still have no idea what is the point cem tries to express.

Nor I know what should the ASSERT() macro do in the kernel. If the
patch above really about replacing panic() with _K_ASSERT, then I most
likely agree with it, since the error catched is not due to the on-disk
metadata corruption.