From owner-freebsd-embedded@FreeBSD.ORG Thu Aug 22 07:12:48 2013 Return-Path: Delivered-To: freebsd-embedded@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 5CE8756B for ; Thu, 22 Aug 2013 07:12:48 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from mail-ob0-f174.google.com (mail-ob0-f174.google.com [209.85.214.174]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 20A7923F2 for ; Thu, 22 Aug 2013 07:12:48 +0000 (UTC) Received: by mail-ob0-f174.google.com with SMTP id wd6so2906718obb.33 for ; Thu, 22 Aug 2013 00:12:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-gm-message-state:sender:subject:mime-version:content-type:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=opaVQiynfFI+/wauTRy0AqpGCIBfQuVF+t3xH80fcLM=; b=cbviUe84Fh+c0g3Gkj63SVn+A4DvBSxB0avzX8JpGTZOJGmVEBSY3RvKFtvdSchO7Q UrWWuLJ84TSo6JydGLPcNCVoMSgnHS63ppk3k337dLOm2ejXHhJal9XpxJn2MOr0YFBI xLIAnv+SEcTWX0ck43OXr0td+QKMNdnSpZDfisE8eiUem2zKRiIT2tSmfKh8QuE73BK9 EpTIyHgVWXDufAd8+qFGb7uPdoNmE1EPl6Fi8rsiX60NtTiUgEqoGUXWDnbcG7BNNRiy MHVXkvxt4bFnJxv/q2uwTY8Z6YToacyFaU9Pih0PjGYnz1a3VmGollmqq8n+O8THFYr0 jD9Q== X-Gm-Message-State: ALoCoQka6Zt8wc56pdQfyUc71OKQrauitnX/aeA4NLWpznqgilSiQkubSN20/jaTs3tyPUM7QCU8 X-Received: by 10.60.47.76 with SMTP id b12mr891941oen.78.1377155567319; Thu, 22 Aug 2013 00:12:47 -0700 (PDT) Received: from 53.imp.bsdimp.com (50-78-194-198-static.hfc.comcastbusiness.net. [50.78.194.198]) by mx.google.com with ESMTPSA id rr6sm16784006oeb.0.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 22 Aug 2013 00:12:46 -0700 (PDT) Sender: Warner Losh Subject: Re: [PATCH] SDIO support for Globalscale Dreamplug Mime-Version: 1.0 (Apple Message framework v1085) Content-Type: text/plain; charset=us-ascii From: Warner Losh In-Reply-To: <5215AD32.3080800@bakulin.de> Date: Thu, 22 Aug 2013 01:12:44 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: <3C9989C8-BB72-4BD6-9246-4AD3790D4732@bsdimp.com> References: <20130702145905.GA1847@olymp.kibab.com> <51D3097A.8010601@FreeBSD.org> <51D3282C.1090701@bakulin.de> <20130703222002.GA60491@olymp.kibab.com> <51D50C55.1040300@myspectrum.nl> <51D531CB.3060300@bakulin.de> <51D5FE4C.9060102@bakulin.de> <20130821095849.GA7322@olymp.kibab.com> <5215AD32.3080800@bakulin.de> To: Ilya Bakulin X-Mailer: Apple Mail (2.1085) Cc: "freebsd-arm@freebsd.org" , Alexander Motin , "freebsd-embedded@freebsd.org" X-BeenThere: freebsd-embedded@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Dedicated and Embedded Systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Aug 2013 07:12:48 -0000 On Aug 22, 2013, at 12:18 AM, Ilya Bakulin wrote: > Hi Adrian, >=20 > On 21.08.13 23:37, Adrian Chadd wrote: >> Hi! >>=20 >> The marvell wifi stuff isn't ARM specific, right? So it should live = in >> dev/ rather than arm/ >=20 > Furthermore, it's only partly SDIO-specific. The same driver should = work > for USB- and PCIe-based versions of Marvell Avastar 88W8787 and = 88W8797. > The Linux driver is split into several files, by the way, for PCIe, = USB > and SDIO, then for station and AP mode. We don't have any drivers in the tree that are this bus agnostic. Would = be cool to grow some :) > I think the best way to organize the code is to split it in layers, = like > it is for ath. > I didn't know that the code is going to be universal when I started to > code the driver, > so that's why if is in sys/arm/mv. Makes sense. > The code in Linux driver is clean and understandable, although I would > prefer to get the documentation for the chipset and not use Linux as = the > single source of information. > What's with the licensing in this case by the way? Copying ideas and facts: no problem. Copying code: you must adhere to the license if you copied enough to be = covered under copyright law.... It's complicated and best avoided.