From owner-freebsd-bugs Mon Jul 17 06:52:47 1995 Return-Path: bugs-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id GAA00396 for bugs-outgoing; Mon, 17 Jul 1995 06:52:47 -0700 Received: from deep-thought.demos.su (root@deep-thought.demos.su [192.91.186.133]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id GAA00390 for ; Mon, 17 Jul 1995 06:52:42 -0700 Received: by deep-thought.demos.su id RAA00516; (8.6.11/D) Mon, 17 Jul 1995 17:42:55 +0400 To: bugs@freebsd.org, Thomas Gellekum References: <199507171017.MAA29201@ghpc6.ihf.rwth-aachen.de> In-Reply-To: <199507171017.MAA29201@ghpc6.ihf.rwth-aachen.de>; from Thomas Gellekum at Mon, 17 Jul 1995 12:17:43 +0200 (MET DST) Message-ID: Organization: DEMOS Date: Mon, 17 Jul 1995 17:42:54 +0400 (MSD) X-Mailer: Mail/@ [v2.40 FreeBSD] From: =?KOI8-R?Q?=E1=CE=C4=D2=C5=CA_=FE=C5=D2=CE=CF=D7?= aka "Andrey A. Chernov, Black Mage" X-Class: Fast Subject: Re: add setlocale() to more(1) Lines: 29 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Length: 821 Sender: bugs-owner@freebsd.org Precedence: bulk In message <199507171017.MAA29201@ghpc6.ihf.rwth-aachen.de> Thomas Gellekum writes: >Moin, >I have added a call to setlocale() to more(1) to make it aware of >different character encodings. The patch is attached below. >+ setlocale(LC_CTYPE, ""); >+ Please, never do such things, reasons list: 1) 'More' limited to 8bit chars only, so setlocale here cause it break all rune (16bit) chars. Supporting of 16bit chars require total 'more' rewritting. 2) Support for 8bit chars already exists, but activates differently: all you need to do setenv ENABLE_STARTUP_LOCALE Check /etc/sysconfig for more detailed example. -- Andrey A. Chernov : ache@FreeBSD.org : From 33th IETF FidoNet: 2:5020/230.3 : Stockholm RELCOM Team,FreeBSD Team :