From nobody Tue Mar 3 12:18:21 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fQFFV24sxz6T39y; Tue, 03 Mar 2026 12:18:22 +0000 (UTC) (envelope-from brooks@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fQFFV1T12z3brB; Tue, 03 Mar 2026 12:18:22 +0000 (UTC) (envelope-from brooks@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1772540302; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bOyNk1wZ68Xu2JEPA4p6+VSELfYKB8WyrtWpZXDyh9g=; b=Yy/wCsCApwTbnFc+fgD0CC1W1dbdvUsLVImHT7wjwqNFwfqBIxiWTiHRvug47vTQ+y60kv IZzGXqn5eL8KBRdzIHwpdOqpTJYhroArFVUsRkBU4YrZ1AfFKiFISBWK+OHBNcgx1YKauk Cvf06HKDl97iK8YgcM/QdEmU7ZR+jlcfVeatJdJOQjKjNCFT8onwdlKCQRvApwqbL5UDQ6 GKjAeF7kYUkIanpT80pbSF7PWvb7vMmAFoE4xtVNDzOMG9L1BXBUSe+4l/8zQvC9Idym56 /UWoxs9DyjKyVfZ0nL1oRQv9SZMCs1kSoLYovoOyEpirCCqTxlLwsPvgE18yPQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1772540302; a=rsa-sha256; cv=none; b=QMnCLHDHWpscU7rG2dTC9mrw93B52CdUppZUPorBq3oM21+y9VWMoBiphaZ3R0u/nakC7d Li0/nhAGCf9Cl1DPSWxH12FZr5CQD+6HcFFHfRHac/cyvI1tQzjbIwtmfjrF3HCplr4LrN lZPytbof3HrpLgVjK4ozkPVdfX7GP/f89/5vX6evikYEIlmdSRKnZHJj0CyMIQ/mB4tAOa RcZ+slMVcq4/dmIBB2fKfaLuqG3db/97OS3blCqBc7IYCupdtXGl1mZYNSEdUvihN8O8ZI 85Mf6ROyDQ1tqlzzrbYq/3CCZgcgOZRId+3l324QnPGl7DJ8bKZ8819mFR8sbA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1772540302; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bOyNk1wZ68Xu2JEPA4p6+VSELfYKB8WyrtWpZXDyh9g=; b=wCqxwq8NeEJWnrc0yqtHDBdPPTpLiVCsj8DaMcrbJ+9sJmUbt1AdMkEHMhdLKoXMrldgZw nEuOAmBtAzf/xeJgP+Qaj7V/2PLRxlBSCtkPg90FfAv61LqB5Gf7mnFfvkmRsBeDnsGPpa Jo0lgdP2FRZS0CcRfpu+rEd+28HaB/1irv4GPDb+mLzG5HnJZWogPo8kRV3LhEzXxt6Ghx 5J936ImdR6JSuBW00JBq32531hcbEguc1CryxnzS6PlJH3vEae7+HhOusD/FJneHlZW3kr EHz213c1+HLFfhHeipN+epURk7msuDI2S+PB77YqvdprJEC55UcKG2+jdSmDwA== Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: brooks/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4fQFFV0Ww6zJVZ; Tue, 03 Mar 2026 12:18:22 +0000 (UTC) (envelope-from brooks@freebsd.org) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id 74D9B3C01A0; Tue, 03 Mar 2026 12:18:21 +0000 (UTC) Date: Tue, 3 Mar 2026 12:18:21 +0000 From: Brooks Davis To: Warner Losh Cc: Enji Cooper , src-committers , "" , "" Subject: Re: git: 912864912b71 - main - Run `make obj` before running `make test-includes` Message-ID: References: <69a678f3.3f811.148b0d7d@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Mar 03, 2026 at 04:25:48AM -0700, Warner Losh wrote: > On Mon, Mar 2, 2026, 11:00???PM Enji Cooper wrote: > > > The branch main has been updated by ngie: > > > > URL: > > https://cgit.FreeBSD.org/src/commit/?id=912864912b71951f9a636190b1dba80528f588eb > > > > commit 912864912b71951f9a636190b1dba80528f588eb > > Author: Enji Cooper > > AuthorDate: 2026-03-03 05:59:50 +0000 > > Commit: Enji Cooper > > CommitDate: 2026-03-03 05:59:56 +0000 > > > > Run `make obj` before running `make test-includes` > > > > Before this change, `make test-includes` (run as part of buildworld) > > would place test files in the current directory, which would clutter up > > git clones. Run `make obj` beforehand to ensure that the files are put > > in `${.OBJDIR}` instead of `${.CURDIR}`. This helps cut down on the > > noise significantly when running commands like `git status`. > > > > I've never seen this happen. .OBJDIR is created automatically for me always > for the last 5 years... I run buildworld all the time. Can you explain when > / how it happens more specifically or back out the change? The commit message is unintentionally misleading and incomplete. I hit the problem a week or so ago when fixing gcc12 builds and lacked the time to follow up. test-includes is fine as part of buildworld, but when run directly from src does fill tools/build/test-includes with .c files if you blow away the objdir (which seems to the the only reliably way to cause test-includes to retest some more complex cases.) -- Brooks