From nobody Fri Jul 31 16:59:29 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hBXNh4PMdz6n8q4; Fri, 31 Jul 2026 16:59:32 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hBXNh1mz6z40X5; Fri, 31 Jul 2026 16:59:32 +0000 (UTC) (envelope-from kevans@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785517172; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=NuZV2dL+GnHpWASh5a2a7NLJ8zL7wfZYsT7U7bI2tSw=; b=GX1vsLtvRz+lSFGgRCYOTwCxJr1shqeHcUczVcYC5GQ3QNw9iPvjoWsweAsobmkHGgcOGG auXsKg3vIKqNBD4zU/8qlqvUCS64qqJRcmrvmimCnqQlaHvIo+PDTHj200UPOeot2S4hoU +l5loSmQGBUQFMmX9BsceoLThn8lT00IqTCwpkRw0MOhfCYdCRrJLwdwsP1Cw8DVOhuBPP jJj8OZ3HFFdwJIluFwxIo4ENVwkYIDx6k5PuFyLyYVODAZNKfLGPF8WsLeqmN1xnNfTx3s f9uyDbRCvljlShs246YwdLPVprXqE37HLaE+6++mQTIoLCgbCrGdMB5T/mN7Hg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785517172; a=rsa-sha256; cv=none; b=WlCX18zkFcw1hsWJQAMtaOSxtqHQtbN7qwadnNhZ9Vrh152xg/RbvGD9QrqQdhT68COruk TKQ1hb+u9TQiIzATVHu1cL5CP5GvDIhUDwUBd5MGlT5DoYVaCHR1SR/yxFg1T9ZyzmDVvW 3LNgatK8KEi8qWx/S9qCwHoLW4t8xzlAjtS8cb02z70NR5ocP5ujxyOC6Hau+UIEZpiNsZ qOPGZ4GZ9qeCVmOTt89ErxfXE4vQCUYlX5G/SaRjRR1UFcXP7W/4+3MPU6b5GMF8MvPtED chmxXfJWjGB8078+q3IP3H9FkBC4GA4Gb0Ae882d0T/ScoX6GWcR7b0/7AflDw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785517172; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=NuZV2dL+GnHpWASh5a2a7NLJ8zL7wfZYsT7U7bI2tSw=; b=AQlI5nCgjWVsVtHjDj28IvXpnmBBGDgziCNaC8YW83IujTFv/WikDHDAzkrniN2VwMDBf0 Jd3i4/87jrZXhFXKGalXLrqmsQ13ddUoPbNRHXergyKHBdbNIepdsWMrdFqlES0ImPqpqb fKZoZzGvVpQ+jjkKMrOpe/OeVvofWWtRYhYdvR9BaaLsmdFiXn4T2BCHsKnV2e9wfkEU72 PTum6QLcqNN/SRuaxlboPgyaONVS6Eh939v6dWRWmexyN6ujq+g2NOSrDGGX5ZW4zpWBiR 2qm3GoceSLHWcE72HzIpdnnP0w+hZOKEUwoLxHQxwejRkqokWptxF3F8eCL4eQ== Received: from [10.9.4.95] (unknown [209.182.120.176]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: kevans/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4hBXNg1H3WzrJJ; Fri, 31 Jul 2026 16:59:31 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Message-ID: <8f33c455-680b-4ac8-804f-7c63b9915363@FreeBSD.org> Date: Fri, 31 Jul 2026 11:59:29 -0500 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: dd235f097af4 - main - route(8): Add prefsrc option in netlink To: Pouria Mousavizadeh Tehrani , Shawn Webb Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <6a6917c5.1e42d.6373b3b9@gitrepo.freebsd.org> <2405606b-929d-49ba-97b6-c57eb28b9eaa@FreeBSD.org> Content-Language: en-US From: Kyle Evans Autocrypt: addr=kevans@FreeBSD.org; keydata= xjMEWySaMRYJKwYBBAHaRw8BAQdAdk/Fqvvw2gwIzw2l1UAbv5mrT35Y5ylfHyUBEcWY3AzN H0t5bGUgRXZhbnMgPGtldmFuc0BGcmVlQlNELm9yZz7ClgQTFggAPgIbAwULCQgHAgYVCgkI CwIEFgIDAQIeAQIXgBYhBPv/ZC7g03RcLBP+TBlOtBOHRwt7BQJlp2YoBQkQJmZ1AAoJEBlO tBOHRwt7krYBAPnGTE/v9EcirWF5oGU+J19nr0wOpPCQzMOxCf5e2km5AQDHIznIhaLvZYUw LlxiBE7MEs/2w4WfXRgW+LuAkzedCc44BFskmjESCisGAQQBl1UBBQEBB0B84DgMSsY6hG+1 o57XJAuqj+dVfG+esKnEiO6T886KYAMBCAfCfgQYFggAJgIbDBYhBPv/ZC7g03RcLBP+TBlO tBOHRwt7BQJlp2ZOBQkQJmadAAoJEBlOtBOHRwt75v8A/Aq5ti6ACDG6/Hfodp9rfed9UQIH q45o6ymUj2TnhTJWAP45Wtv80BB+TiEcWCG7kcOYB3hcqZlD8k8vfito8b3KBA== In-Reply-To: <2405606b-929d-49ba-97b6-c57eb28b9eaa@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/31/26 11:05, Pouria Mousavizadeh Tehrani wrote: > Hi Shawn, > > On 7/31/26 19:28, Shawn Webb wrote: >> Hey Pouria, >> >> This commit causes /sbin/route to crash. I will work on getting a core >> dump this weekend. Reverting this commit made /sbin/route happy again. >> I just figured I'd send the email now while I'm thinking about it. >> >> Note that I'm using HardenedBSD, so the core dump might be a little >> bit different than one generated by FreeBSD. >> >> Thanks, >> > > Thank you for the report. > I'll keep an eye out for your email. > It seems like this should be predicated on `prefsrc != NULL`: ``` snl_add_msg_attr_ip(&nw, RTA_PREFSRC, prefsrc); ``` snl_add_msg_attr_ip seems like it'd be happy to dereference `prefsrc`, and we might not have one? Thanks, Kyle Evans