From owner-svn-src-all@FreeBSD.ORG Sun Jun 14 19:02:18 2015 Return-Path: Delivered-To: svn-src-all@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8BC2912E; Sun, 14 Jun 2015 19:02:18 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pa0-x231.google.com (mail-pa0-x231.google.com [IPv6:2607:f8b0:400e:c03::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 531EBCCA; Sun, 14 Jun 2015 19:02:18 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by pacgb13 with SMTP id gb13so21359787pac.1; Sun, 14 Jun 2015 12:02:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=KVA+uOTIOo9R2PEFKu4IYk9AizQMg7MNtQoA31ewl4w=; b=fScLdtMGORLKQeV8w0x7kRFVEApMJ1kF2KIZ2YHFeTLVUpy6MFBAhgFJstAeygR0VA ObNcjOTCjC9MFJz2Nr3UuVuS3XcsmRrc5+2HKJ2VeR444mbEKVXMUHPOwV6It9osHkTY 5Kj0y9hwCEAHvfTGyknVGiRo/8QO/5GLyTRny0i9kwEjZhMgYGAoyncRXJB0zDnvyw4+ qiL01kG3auT62jXuF+kUeNTEzMYVNaV6Zy9L/YqXB7WCpl3dN89xufBpoj2NfCYHrpvx vpNmf2skKA5/ELfgE1FIWqdPgjoQNjqnloMw5YPcjmi2yn4WrcJ9pnjxB1mAUaGp7yWH 3wTQ== X-Received: by 10.68.193.232 with SMTP id hr8mr41668912pbc.145.1434308537790; Sun, 14 Jun 2015 12:02:17 -0700 (PDT) Received: from [192.168.20.7] (c-98-247-240-204.hsd1.wa.comcast.net. [98.247.240.204]) by mx.google.com with ESMTPSA id fd3sm9869049pdb.0.2015.06.14.12.02.16 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 14 Jun 2015 12:02:16 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r284198 - head/bin/ls From: Garrett Cooper X-Mailer: iPhone Mail (12F70) In-Reply-To: Date: Sun, 14 Jun 2015 12:02:15 -0700 Cc: Bruce Simpson , Steve Kargl , Slawa Olhovchenkov , Craig Rodrigues , Marcel Moolenaar , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , Marcel Moolenaar , "src-committers@freebsd.org" Content-Transfer-Encoding: 7bit Message-Id: <887CD9C6-9807-48AF-A7A6-B33F91901414@gmail.com> References: <201506100127.t5A1RdX6051959@svn.freebsd.org> <20150612204309.11dd3391@kan> <20150613024916.GA98218@troutmask.apl.washington.edu> <1434208622.1415.57.camel@freebsd.org> <557C661F.8080104@freebsd.org> <860017ED-D754-450C-865D-2D81A30C2212@xcllnt.net> <20150614100045.GF58397@zxy.spb.ru> <557D55CB.5050009@fastmail.net> <20150614171031.GA5857@troutmask.apl.washington.edu> <557DCBED.2010804@fastmail.net> To: Adrian Chadd X-Mailman-Approved-At: Sun, 14 Jun 2015 21:48:38 +0000 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Jun 2015 19:02:18 -0000 > On Jun 14, 2015, at 11:53, Adrian Chadd wrote: > > We have busybox already - it's called bsdbox, and it's in base, and > we're already using it, and yes, it does pull in libxo. :) > > I'm not worried about the size increase of libxo. That's the wrong > thing to focus on. If it gets much more bloated then I'll poke people > with the big "what are you thinking" stick. The issues people have > aren't size related, they're "this API needs improvement and we have > bugs introduced into tools." > > I do like how zero percent of the comments are "hey, maybe we need > unit tests that run these tools and ensure they output the right > stuff." If this were ${WORK} and I were ${BOSS}, I'd have asked the > libxo developers to include unit tests before/after for each thing > they broke, so we don't have a repeat of this kind of thing. But, this > apparently isn't ${WORK} and I definitely don't want to be anyones > boss, so.. Ugh. I'll write the tests ;(...