From owner-dev-commits-src-main@freebsd.org  Sun Jan 10 21:31:20 2021
Return-Path: <owner-dev-commits-src-main@freebsd.org>
Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 30A224DA8DF;
 Sun, 10 Jan 2021 21:31:20 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4DDVQH69wXz3kcg;
 Sun, 10 Jan 2021 21:31:19 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from tom.home (kib@localhost [127.0.0.1])
 by kib.kiev.ua (8.16.1/8.16.1) with ESMTPS id 10ALV615058424
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Sun, 10 Jan 2021 23:31:10 +0200 (EET)
 (envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 10ALV615058424
Received: (from kostik@localhost)
 by tom.home (8.16.1/8.16.1/Submit) id 10ALV6v2058423;
 Sun, 10 Jan 2021 23:31:06 +0200 (EET)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
 using -f
Date: Sun, 10 Jan 2021 23:31:06 +0200
From: Konstantin Belousov <kostikbel@gmail.com>
To: Jessica Clarke <jrtc27@freebsd.org>
Cc: Mitchell Horne <mhorne@freebsd.org>,
 "src-committers@freebsd.org" <src-committers@freebsd.org>,
 "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>,
 "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org>
Subject: Re: git: facdd1cd2045 - main - cgem: add 64-bit support
Message-ID: <X/tyGljg0gdzab2K@kib.kiev.ua>
References: <202101102053.10AKrGqv070360@gitrepo.freebsd.org>
 <B11437E6-5865-460B-92A0-62D82F2BBEFC@freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <B11437E6-5865-460B-92A0-62D82F2BBEFC@freebsd.org>
X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM,
 NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on tom.home
X-Rspamd-Queue-Id: 4DDVQH69wXz3kcg
X-Spamd-Bar: ----
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [-4.00 / 15.00];
	 REPLY(-4.00)[]
X-BeenThere: dev-commits-src-main@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Commit messages for the main branch of the src repository
 <dev-commits-src-main.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-src-main>, 
 <mailto:dev-commits-src-main-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-src-main/>
List-Post: <mailto:dev-commits-src-main@freebsd.org>
List-Help: <mailto:dev-commits-src-main-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-src-main>, 
 <mailto:dev-commits-src-main-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 10 Jan 2021 21:31:20 -0000

On Sun, Jan 10, 2021 at 09:17:48PM +0000, Jessica Clarke wrote:
> On 10 Jan 2021, at 20:53, Mitchell Horne <mhorne@FreeBSD.org> wrote:
> > diff --git a/sys/dev/cadence/if_cgem.c b/sys/dev/cadence/if_cgem.c
> > index 3c5277452469..77337e977dcc 100644
> > --- a/sys/dev/cadence/if_cgem.c
> > +++ b/sys/dev/cadence/if_cgem.c
> > @@ -77,6 +77,14 @@ __FBSDID("$FreeBSD$");
> > #include <dev/mii/mii.h>
> > #include <dev/mii/miivar.h>
> > 
> > +#ifdef EXT_RESOURCES
> > +#include <dev/extres/clk/clk.h>
> > +#endif
> > +
> > +#if INTPTR_MAX == INT64_MAX
> > +#define CGEM64
> > +#endif
> 
> This isn't going to work with CHERI. Perhaps a BUS_SPACE_MAXADDR check,
> or SIZE_MAX? The former is probably preferable for PAE systems.

Wouldn't it be spelled as __LP64__ ?