From owner-freebsd-ports@FreeBSD.ORG Thu Dec 18 01:23:00 2003 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 232C516A4CE; Thu, 18 Dec 2003 01:23:00 -0800 (PST) Received: from geekpunk.net (adsl-19-197-182.bna.bellsouth.net [68.19.197.182]) by mx1.FreeBSD.org (Postfix) with ESMTP id 45A0343D45; Thu, 18 Dec 2003 01:22:58 -0800 (PST) (envelope-from bandix@geekpunk.net) Received: from localhost.my.domain (taran [127.0.0.1]) by geekpunk.net (8.12.8p1/8.12.6) with ESMTP id hBI9N9Ym009613; Thu, 18 Dec 2003 03:23:09 -0600 (CST) (envelope-from bandix@geekpunk.net) Received: (from bandix@localhost) by localhost.my.domain (8.12.8p1/8.12.8/Submit) id hBI9N8Ic009612; Thu, 18 Dec 2003 03:23:08 -0600 (CST) Date: Thu, 18 Dec 2003 03:23:08 -0600 From: "Brandon D. Valentine" To: Joe Marcus Clarke Message-ID: <20031218092308.GB8284@geekpunk.net> References: <20031218074613.GA8284@geekpunk.net> <1071733971.59139.34.camel@shumai.marcuscom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1071733971.59139.34.camel@shumai.marcuscom.com> User-Agent: Mutt/1.4.1i cc: nc-rotherdo@netcologne.de cc: freebsd-gnome@freebsd.org cc: FreeBSD Ports Subject: Re: prying x11-wm/wmakerconf loose from gnome X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Dec 2003 09:23:00 -0000 On Thu, Dec 18, 2003 at 02:52:52AM -0500, Joe Marcus Clarke wrote: > On Thu, 2003-12-18 at 02:46, Brandon D. Valentine wrote: > > Which of the gnome components contains the "menus" and should be tested > > against? Should I submit PRs+patches or is there some ports or gnome > > committer who would prefer to clean these up? They both should be > > simple to fix. > > I agree this is a bug in wmakerconf, but someone will need to determine > which GNOME component to check for, then modify the HAVE_GNOME test to > be: That was exactly what I was asking for advice on. > .if ${HAVE_GNOME:Mcomponent}!="" > ... > > At that point, the problem should go away. Given that no one has truly > migrated this port to the new GNOME infrastructure, that "component" > could be gtkhtml (however, I'm sure gnomelibs would suffice). I've just been digging around on the web and it looks like gnome2wmaker is unmaintained, both as a port and in general. The maintainer was set back to freebsd-ports in early November 2003 by kris. The last time it was modified before that (save the pkg-comment cleanup) was December 2001. I seriously doubt that it works with gnome2 and I'm certainly not interested in finding out. I doubt anyone uses this. In light of that realization, my recommended fix follows my sig in patch form (removing gnome2wmaker references from the wmakerconf port altogther). I also recommend that the gnome2wmaker port be moved to the Attic since it hasn't been ported to gnome2, there is no FreeBSD maintainer, and there is no upstream maintainer. HTH, Brandon D. Valentine -- brandon@dvalentine.com http://www.geekpunk.net Pseudo-Random Googlism: leaves is good for boils and swollen hands and feet Index: ports/x11-wm/wmakerconf/Makefile =================================================================== RCS file: /home/ncvs/ports/x11-wm/wmakerconf/Makefile,v retrieving revision 1.34 diff -u -r1.34 Makefile --- ports/x11-wm/wmakerconf/Makefile 28 Oct 2003 09:55:31 -0000 1.34 +++ ports/x11-wm/wmakerconf/Makefile 18 Dec 2003 09:08:11 -0000 @@ -7,6 +7,7 @@ PORTNAME= wmakerconf PORTVERSION= 2.8.1 +PORTREVISION= 1 CATEGORIES= x11-wm MASTER_SITES= ${MASTER_SITE_NETBSD} @@ -34,14 +35,6 @@ CONFIGURE_ARGS= --with-wmakerdir="${X11BASE}/share/WindowMaker" .include - -.if defined(HAVE_GNOME) -BUILD_DEPENDS+= gnome2wmaker:${PORTSDIR}/x11-wm/gnome2wmaker -RUN_DEPENDS+= gnome2wmaker:${PORTSDIR}/x11-wm/gnome2wmaker -PLIST_SUB+= GNOME:="" -.else -PLIST_SUB+= GNOME:="@comment " -.endif post-configure: @${PERL} -pi -e 's|%%X11BASE%%|${X11BASE}| ; s|%%LOCALBASE%%|${LOCALBASE}|' \