From owner-freebsd-net@freebsd.org Thu Jul 23 09:02:04 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 343E03776CB; Thu, 23 Jul 2020 09:02:04 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BC5tg5hktz4Hbg; Thu, 23 Jul 2020 09:02:03 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.codepro.be", Issuer "Let's Encrypt Authority X3" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id 9209A18D33; Thu, 23 Jul 2020 09:02:03 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id DD3AF3D804; Thu, 23 Jul 2020 11:02:01 +0200 (CEST) From: "Kristof Provost" To: "Bjoern A. Zeeb" Cc: "John-Mark Gurney" , freebsd-net@freebsd.org, freebsd-current@freebsd.org Subject: Re: somewhat reproducable vimage panic Date: Thu, 23 Jul 2020 11:02:01 +0200 X-Mailer: MailMate (1.13.1r5671) Message-ID: In-Reply-To: <8B72C0B9-9CF0-4557-81D7-77190775805C@lists.zabbadoz.net> References: <20200721091654.GC4213@funkthat.com> <20200721113153.42d83119@x23> <20200721202323.GE4213@funkthat.com> <38F5A3A6-B578-4BA4-8F69-C248163CB6E0@libassi.se> <20200722060514.GF4213@funkthat.com> <20200722193443.GG4213@funkthat.com> <6C149617-55BB-4A87-B993-195E5E133790@lists.zabbadoz.net> <20200722221509.GI4213@funkthat.com> <2FFC49F9-83DE-4FA1-A47F-1D8A7AF4B241@FreeBSD.org> <6847FB6B-0B1A-43C7-B567-15BF21AB5D56@FreeBSD.org> <8B72C0B9-9CF0-4557-81D7-77190775805C@lists.zabbadoz.net> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jul 2020 09:02:04 -0000 On 23 Jul 2020, at 11:00, Bjoern A. Zeeb wrote: > On 23 Jul 2020, at 8:09, Kristof Provost wrote: > >> On 23 Jul 2020, at 9:19, Kristof Provost wrote: >>> On 23 Jul 2020, at 0:15, John-Mark Gurney wrote: >>>> So, it's pretty easy to trigger, just attach a couple USB ethernet >>>> adapters, in my case, they were ure, but likely any two spare >>>> ethernet >>>> interfaces will work, and wire them back to back.. >>>> >>> I’ve been able to trigger it using epair as well: >>> >>> `sudo sh testinterfaces.txt epair0a epair0b` >>> >>> I did have to comment out the waitcarrier() check. >>> >> I’ve done a little bit of digging, and I think I’m starting to >> see how this breaks. >> >> This always affects the jailed vlan interfaces. They’re getting >> deleted, but the ifp doesn’t go away just yet because it’s still >> in use by the multicast code. >> The multicast code does its cleanup in task queues, > > Wow, did I miss that back then? Did I review a change and not notice? > Sorry if that was the case. > > Vnet teardown is blocking and forceful. > Doing deferred cleanup work isn’t a good idea at all. > I think that is the real problem here. > > I’d rather have us fix this than putting more bandaids into the > code. > Yeah, agreed. I think hselasky has a better fix: https://reviews.freebsd.org/D24914 I just saw his e-mail in a different thread. Best regards, Kristof