From owner-cvs-all  Mon Dec  9 12:22: 8 2002
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 7525437B401; Mon,  9 Dec 2002 12:22:06 -0800 (PST)
Received: from genius.tao.org.uk (genius.tao.org.uk [212.135.162.51])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id E394F43E4A; Mon,  9 Dec 2002 12:22:05 -0800 (PST)
	(envelope-from joe@genius.tao.org.uk)
Received: by genius.tao.org.uk (Postfix, from userid 100)
	id 149AF4215; Mon,  9 Dec 2002 20:21:04 +0000 (GMT)
Date: Mon, 9 Dec 2002 20:21:03 +0000
From: Josef Karthauser <joe@FreeBSD.org>
To: Nate Lawson <nate@root.org>
Cc: cvs-all@freebsd.org, cvs-committers@freebsd.org
Subject: Re: cvs commit: src/sys/dev/usb ohci.c
Message-ID: <20021209202103.GA658@genius.tao.org.uk>
References: <20021209014609.9F72F37B50C@hub.freebsd.org> <Pine.BSF.4.21.0212091149270.25027-100000@root.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="AhhlLboLdkugWU4S"
Content-Disposition: inline
In-Reply-To: <Pine.BSF.4.21.0212091149270.25027-100000@root.org>
User-Agent: Mutt/1.5.1i
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG


--AhhlLboLdkugWU4S
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Dec 09, 2002 at 11:58:09AM -0800, Nate Lawson wrote:
> On Sun, 8 Dec 2002, Josef Karthauser wrote:
> > joe         2002/12/08 17:41:24 PST
> >=20
> >   Modified files:
> >     sys/dev/usb          ohci.c=20
> >   Log:
> >   MFNetBSD: (partial 1.133)
> >   - In ohci_close_pipe, wait 1ms after removing an ED to avoid possible=
 race
> >     condition.
> >  =20
> >   Approved by:    re (rwatson)
>=20
> Wouldn't it be better to use a mtx or tsleep/wakeup?  A delay leaves the
> race, only making it non-deterministic.
>=20

Probably, got a patch :)?

Joe
--=20
Josef Karthauser (joe@tao.org.uk)	       http://www.josef-k.net/
FreeBSD (cvs meister, admin and hacker)     http://www.uk.FreeBSD.org/
Physics Particle Theory (student)   http://www.pact.cpes.sussex.ac.uk/
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D An eclectic mix of fact an=
d theory. =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D

--AhhlLboLdkugWU4S
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (FreeBSD)

iEYEARECAAYFAj30+y4ACgkQXVIcjOaxUBZHpgCdG9hDet+0YOrGoEzKTuZk9fDe
EWoAoIW9i7OIBdDVV16YBLCRIsdADVXc
=ykaT
-----END PGP SIGNATURE-----

--AhhlLboLdkugWU4S--

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message