From nobody Sat Dec 10 18:46:09 2022 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NTxgC4ptyz4k9Qf; Sat, 10 Dec 2022 18:46:15 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NTxgC402mz3PhX; Sat, 10 Dec 2022 18:46:15 +0000 (UTC) (envelope-from jbeich@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1670697975; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KNuYGT2HOghLJ5WlKmZ1OGtGa2y9txn7GUNqdRlzNTU=; b=Zvtrzp0bkKLVqSkqcZ/aNaAjTXJ2jldZ0FQf7yyR4y8cA4xJnJ+fZRAJpWOED9/2LqCXzL mMmZWO3xV3aDH9oXk3riQv67b1CAQow6aO2aisZGJ4IguYAIAlaFvQVelzVHPr79iQM/+k +qY3bjDZFUwyUT6j4aXxuN+j1veCXMcWPa2ud0zd88JlYJCIgZvIXgYFwYovs4Y7uN3V4f 5GLmRpPolq54vLkQUO0DxFZ7Xhn8Q1YQL2l3AmjQ5NASX9lEc7npciMds2hl5tewyXnhSf DeTb2yXAKgLpnPFxU8N9+hTHJrOe7riij08XQdZGzMgBeWFg3Z+TnU8zPm8UDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1670697975; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KNuYGT2HOghLJ5WlKmZ1OGtGa2y9txn7GUNqdRlzNTU=; b=NrJI26zjw4/YCsR+tQoySMRARXxGPneSmBQlpV1Z2/eLxWkQdN2cbTHTEaG4xkVbk1BuXy hBDDo/V649c2BjB9J3DJUH7QWU4O5RyPvEyTbzXsNeOnIU+7fpdgxyRGSLUoj4Gqo7+w/w bjvdEKGJjs/dMXdPWqtjoXHNCY++bbVBav6acCE5cePwBBOkXNvDklWyDZwURWm0RBRvhB BuqDI73lY7ikIvST6uKdUap3acj6YqXigB0aDCTw4eh8ZeZEfIUJoUbeJdJb4RNvdZcaK5 W7VtXKpkxUl9D4yhXes+MtnnXsHorrEBjtgVLLFqmVg58kxX4+XQ9jgs/0D5DQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1670697975; a=rsa-sha256; cv=none; b=naKOc7rHQxHKWuDPosn1r/yDO9T2UjwkJyStB2ITs979+JCBgjqOuY/PrxQM/hvhsqfZ4q Lg6QLUO6W7PfxXYiOpQzNUz9G0w8IwpRQC1ESwxTJtz48ea1fXuL0/HMSwafyeeIYVa5nf aGqC65laQJQbrAB/rZFFO753xoNq9XRzw/PNjve/asmXqLFrKOiuZkF9epAjFW/pu6neDg gN3851mzkcPCAponGr4O8D/WcuPKkdNN5Lv1l/eUpTf9ZiCPEERSaEKkvkBzfeE2xAd4Xn ne0QeJ0pFYdImyoJuPC7HYXISdcMTCf+QsLPRnsctThKOdJfnROY4yB9bGpg0Q== Received: by freefall.freebsd.org (Postfix, from userid 1354) id 64B3C1F10A; Sat, 10 Dec 2022 18:46:15 +0000 (UTC) From: Jan Beich To: Emmanuel Vadot Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 799245580a71 - main - graphics/mesa: Do not add USE_LDCONFIG for every mesa ports In-Reply-To: <202212081901.2B8J1frs012470@gitrepo.freebsd.org> (Emmanuel Vadot's message of "Thu, 8 Dec 2022 19:01:41 GMT") References: <202212081901.2B8J1frs012470@gitrepo.freebsd.org> Date: Sat, 10 Dec 2022 19:46:09 +0100 Message-ID: <359n-t7v2-wny@FreeBSD.org> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain X-ThisMailContainsUnwantedMimeParts: N Emmanuel Vadot writes: > Not every mesa ports provides shared libraries intented for dynamic uses > so stop running ldconfig script for those ports. [...] > diff --git a/graphics/mesa-dri/Makefile b/graphics/mesa-dri/Makefile > index ac87f4cef889..e4fe1b570261 100644 > --- a/graphics/mesa-dri/Makefile > +++ b/graphics/mesa-dri/Makefile > @@ -26,6 +26,8 @@ ZSTD_DESC= Use ZSTD for shader cache > ZSTD_LIB_DEPENDS= libzstd.so:archivers/zstd > ZSTD_MESON_ENABLED= zstd > > +USE_LDCONFIG= yes OpenGL drivers in mesa-dri lack headers, SONAME and cannot be used by ld(1) via -l due to missing "lib" prefix (unless using -l: syntax which is generally useful to force static linking of a specific lib). For dlopen(3) mesa-libs uses ${PREFIX}/lib/dri (or LIBGL_DRIVERS_PATH) and vulkan-loader with ${PREFIX}/share/vulkan/icd.d/*.json (or VK_ICD_FILENAMES) instead of ldconfig(8) hints. lang/clover is probably similar as there's no API outside of devel/ocl-icd using dlopen(3) with ${PREFIX}/etc/OpenCL/vendors/*.icd diff --git a/graphics/mesa-dri/Makefile b/graphics/mesa-dri/Makefile index 956cfb1d6f3e..94c8503053a7 100644 --- a/graphics/mesa-dri/Makefile +++ b/graphics/mesa-dri/Makefile @@ -27,8 +27,6 @@ ZSTD_DESC= Use ZSTD for shader cache ZSTD_LIB_DEPENDS= libzstd.so:archivers/zstd ZSTD_MESON_ENABLED= zstd -USE_LDCONFIG= yes - .include .include "${.CURDIR:H:H}/graphics/mesa-dri/Makefile.common" diff --git a/lang/clover/Makefile b/lang/clover/Makefile index c8f6dca6412b..c8325d1aad63 100644 --- a/lang/clover/Makefile +++ b/lang/clover/Makefile @@ -20,8 +20,6 @@ LIB_DEPENDS= libOpenCL.so:devel/ocl-icd \ RUN_DEPENDS= libclc>=0.3.0:devel/libclc \ opencl>=0:devel/opencl -USE_LDCONFIG= yes - .include .include "${.CURDIR:H:H}/graphics/mesa-dri/Makefile.common"