From owner-svn-src-all@freebsd.org Thu Mar 29 16:19:47 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B7BC1F59E2E for ; Thu, 29 Mar 2018 16:19:47 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1a.eu.mailhop.org (outbound1a.eu.mailhop.org [52.58.109.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 41C5A7659D for ; Thu, 29 Mar 2018 16:19:46 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-User: fa8d8c7a-336c-11e8-91c6-33ffc249f3e8 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound1.eu.mailhop.org (Halon) with ESMTPSA id fa8d8c7a-336c-11e8-91c6-33ffc249f3e8; Thu, 29 Mar 2018 16:19:40 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id w2TGJXXL067388; Thu, 29 Mar 2018 10:19:33 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1522340373.49673.112.camel@freebsd.org> Subject: Re: svn commit: r331728 - in stable/11/etc: . rc.d From: Ian Lepore To: rgrimes@freebsd.org, Marcelo Araujo Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Date: Thu, 29 Mar 2018 10:19:33 -0600 In-Reply-To: <201803291320.w2TDKej2063088@pdx.rh.CN85.dnsmgr.net> References: <201803291320.w2TDKej2063088@pdx.rh.CN85.dnsmgr.net> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Mar 2018 16:19:47 -0000 On Thu, 2018-03-29 at 06:20 -0700, Rodney W. Grimes wrote: > > > > Author: araujo > > Date: Thu Mar 29 04:51:07 2018 > > New Revision: 331728 > > URL: https://svnweb.freebsd.org/changeset/base/331728 > > > > Log: > >   MFC r329817: > I must of missed this when it landed in ^/head > > > > >   The firewall_type is ignored if not set in rc.conf or rc.conf.local, > >   after r190575 there is an option to call rc.firewall with the firewall_type > >   passed in as an argument. > >    > >   Submitted by: David P. Discher > >   Sponsored by: iXsystems Inc. > >   Differential Revision: https://reviews.freebsd.org/D14286 > No one accepted it :-(. > That's not a blocker for committing; plenty of time elapsed to allow anyone to reject the change. IMO, even a flat-out rejection isn't a blocker to committing except for things like random or crypto code that require formal approval (but I'd certainly think hard about committing if people rejected the change, and put some effort into finding a compromise first). There were comments added to the review, which makes citing the review in the commit useful.  I usually also add a note such as '(timed out)' after the url, but I've noticed that doing so ruins the automatic closing of the review and requires you to manually abandon it instead. -- Ian