From owner-p4-projects@FreeBSD.ORG  Mon Aug 14 16:43:14 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 3055E16A4E6; Mon, 14 Aug 2006 16:43:14 +0000 (UTC)
X-Original-To: perforce@FreeBSD.org
Delivered-To: perforce@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E824F16A4E0
	for <perforce@FreeBSD.org>; Mon, 14 Aug 2006 16:43:13 +0000 (UTC)
	(envelope-from rdivacky@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B391243D53
	for <perforce@FreeBSD.org>; Mon, 14 Aug 2006 16:43:13 +0000 (GMT)
	(envelope-from rdivacky@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k7EGhDVp099419
	for <perforce@FreeBSD.org>; Mon, 14 Aug 2006 16:43:13 GMT
	(envelope-from rdivacky@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k7EGhDRh099416
	for perforce@freebsd.org; Mon, 14 Aug 2006 16:43:13 GMT
	(envelope-from rdivacky@FreeBSD.org)
Date: Mon, 14 Aug 2006 16:43:13 GMT
Message-Id: <200608141643.k7EGhDRh099416@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	rdivacky@FreeBSD.org using -f
From: Roman Divacky <rdivacky@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 103865 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Aug 2006 16:43:14 -0000

http://perforce.freebsd.org/chv.cgi?CH=103865

Change 103865 by rdivacky@rdivacky_witten on 2006/08/14 16:42:53

	A few more comments.

Affected files ...

.. //depot/projects/soc2006/rdivacky_linuxolator/compat/linux/linux_emul.c#5 edit
.. //depot/projects/soc2006/rdivacky_linuxolator/i386/linux/linux_machdep.c#50 edit

Differences ...

==== //depot/projects/soc2006/rdivacky_linuxolator/compat/linux/linux_emul.c#5 (text+ko) ====

@@ -190,6 +190,9 @@
 		cup.uaddr2 = NULL;
 		cup.val3 = 0;
 		error = linux_sys_futex(FIRST_THREAD_IN_PROC(p), &cup);
+		/* this cannot happen at the moment and if this happens
+		 * it probably mean there is a userspace bug
+		*/
 		if (error)
 		   	printf(LMSG("futex stuff in proc_exit failed.\n"));
 	}

==== //depot/projects/soc2006/rdivacky_linuxolator/i386/linux/linux_machdep.c#50 (text+ko) ====

@@ -412,6 +412,9 @@
 	}
 	   	
 	if (args->flags & CLONE_THREAD) {
+	   	/* XXX: linux mangles pgrp and pptr somehow
+		 * I think it might be this but I am not sure.
+		 */
 #ifdef notyet
 	   	p2->p_pgrp = td->td_proc->p_pgrp;
 	 	p2->p_pptr = td->td_proc->p_pptr;