From owner-svn-ports-head@freebsd.org Fri Dec 14 07:02:32 2018 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EE1A81318C5B; Fri, 14 Dec 2018 07:02:31 +0000 (UTC) (envelope-from romain@blogreen.org) Received: from marvin.blogreen.org (unknown [IPv6:2a01:e35:8a13:be40:6631:50ff:fed3:111d]) by mx1.freebsd.org (Postfix) with ESMTP id 4EF128EEC9; Fri, 14 Dec 2018 07:02:28 +0000 (UTC) (envelope-from romain@blogreen.org) Received: by marvin.blogreen.org (Postfix, from userid 1001) id 676929D5CC; Fri, 14 Dec 2018 08:02:25 +0100 (CET) Date: Thu, 13 Dec 2018 21:02:25 -1000 From: Romain =?iso-8859-1?Q?Tarti=E8re?= To: Jan Beich Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r487403 - head/databases/puppetdb-cli Message-ID: <20181214070225.GA13003@blogreen.org> References: <201812140259.wBE2xbuT015992@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FL5UXtIhxfXey3p5" Content-Disposition: inline In-Reply-To: X-PGP-Key: http://romain.blogreen.org/pubkey.asc User-Agent: Mutt/1.11.0 (2018-11-25) X-Rspamd-Queue-Id: 4EF128EEC9 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-5.95 / 15.00]; NEURAL_HAM_MEDIUM(-0.99)[-0.993,0]; NEURAL_HAM_SHORT(-0.96)[-0.961,0]; REPLY(-4.00)[] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Dec 2018 07:02:32 -0000 --FL5UXtIhxfXey3p5 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 14, 2018 at 06:19:50AM +0100, Jan Beich wrote: > Romain Tarti=E8re writes: >=20 > > +BROKEN_SSL_REASON_libressl=3D Needs an old version of OpenSSL (older t= han 1.1) >=20 > Does it build fine with DEFAULT_VERSIONS+=3Dlibressl-devel ? Of course not, good catch! Probably the same for openssl-devel but it seems absent as of today, so I don't know if we should add it. > > +.include >=20 > .include would have been enough. Yes, it seems to be okay too. I was following https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.htm= l#dads-after-port-mk > > +.if ${OSVERSION} >=3D 1200085 >=20 > Checking OSVERSION without OPSYS is illegal. DragonFly has OSVERSION=3D99= 99999 > with LibreSSL 2.4.4 in base. >=20 > https://github.com/DragonFlyBSD/DPorts/blob/f18014a15a13/Mk/bsd.port.mk#L= 1184 > https://github.com/DragonFlyBSD/DragonFlyBSD/blob/bd84e83893b2/crypto/lib= ressl/README.DRAGONFLY Fixed! > > +BROKEN_SSL+=3D base >=20 > BROKEN_SSL=3Dbase is *not supported* by USES=3Dssl, and BROKEN_SSL cannot= set > after bsd.port.pre.mk because USES=3Dssl was already processed by that ti= me. D'oh! Maybe this information may have it's place in the Porter's Handbook: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.htm= l#uses-ssl I tried to workaround this by testing OPSYS && OSVERSION && SSL_DEFAULT and setting BROKEN if all conditions are met. Quite ugly, but should get the work done. If you see a better way to fix this, please tell me. Thanks! --=20 Romain Tarti=E8re http://people.FreeBSD.org/~romain/ pgp: 8234 9A78 E7C0 B807 0B59 80FF BA4D 1D95 5112 336F (ID: 0x5112336F) (plain text =3Dnon-HTML=3D PGP/GPG encrypted/signed e-mail much appreciated) --FL5UXtIhxfXey3p5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCAAdFiEEgjSaeOfAuAcLWYD/uk0dlVESM28FAlwTVX4ACgkQuk0dlVES M2+yJwv/etc/eHOcRNjg3Oiov0/TYobvFTtKJ8VU0LHj6NoCrYtiX1UKcrhJbWYl jznJBO19xGMI64RV0yE2w6gFu34jZJjyEF23lVbKvSPicEgUKHeM+yYGiab/CzYs eDmQFLr3Yj0uBi+p3z9iHJWjHKBCNTIZZgxfx77+nWUg+CwdtJTYGS0RSQSS/fdu +3+zjgecLiZ7iFJMvBi0aH9jUk/iTiQfR8yTVif3jhUzocgAtOBp1HNXqtfOMpmf 9aeXsvek/dQXY3GKm4gK6gWVdSGpI0LSqB1RT0zSKmh6I6Cxrn1Ub3Exz8Lzd4Dd /77EZLrtZDNnuBYot4kQq2HFe/AGfjIvIBty67M3fOe9cnZRITLQdUmW4VWm5wxs SAS7InhJDCum6J9xafn1fFvkGMTkY89FbaZdwL7KoV3lJFyGoR7UVhQRh8bEnAHX WAD6twtYMMZeuATg79F7iWp2Ip/Fc0427+dIP6zn/RS21kiPdvAjsvNDaRpyuvam W0Q1ylCe =T/Hc -----END PGP SIGNATURE----- --FL5UXtIhxfXey3p5--