From owner-freebsd-ports-bugs@FreeBSD.ORG Sun May 18 18:50:01 2014 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9BC9B71C for ; Sun, 18 May 2014 18:50:01 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6D3FB2184 for ; Sun, 18 May 2014 18:50:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.8/8.14.8) with ESMTP id s4IIo19G045631 for ; Sun, 18 May 2014 18:50:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s4IIo0hW045622; Sun, 18 May 2014 18:50:00 GMT (envelope-from gnats) Date: Sun, 18 May 2014 18:50:00 GMT Message-Id: <201405181850.s4IIo0hW045622@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org Cc: From: Rusty Nejdl Subject: Re: ports/186610: Update port mail/assp to 14040 build Reply-To: Rusty Nejdl X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 May 2014 18:50:01 -0000 The following reply was made to PR ports/186610; it has been noted by GNATS. From: Rusty Nejdl To: marino@freebsd.org Cc: bug-followup@freebsd.org Subject: Re: ports/186610: Update port mail/assp to 14040 build Date: Sun, 18 May 2014 13:21:13 -0500 --=_f10cb3b33d774096f028f3faf853f693 Content-Transfer-Encoding: 7bit Content-Type: text/plain On 2014-05-13 01:31, John Marino wrote: > Stumbling upon this .... > > Comments: > 1) The fixes don't include stage support, which is mandatory now > 2) The patch set includes several files that aren't actually changed: > - files/510.assp.in > - files/assp.in > - files/patch-assp.pl > - files/pkg-install.in > 3) the assp.pl patch doesn't end in a new line (see patchset) > 4) :U is used, that's got to be changed to :tu now > > In this case, the use of git hurt. The patchset was blindly generated > without noticing either the non-function svnid changes or the missing > carriage return. > > I would fix these problems, then submit a new PR that has the words > "support stage" in the title, with a new patch and then ask for the old > PR to be closed. I suggest this approach because ports that support > stage will be noticed first. Marino, I'm working on this today since I have a quiet moment. Any suggestions on #3? Rusty --=_f10cb3b33d774096f028f3faf853f693 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=UTF-8

On 2014-05-13 01:31, John Marino wrote:

Stumbling upon this ....
 
 Comments:
 1) The fixes don't include stage support, which is mandatory now
 2) The patch set includes several files that aren't actually changed:
 - files/510.assp.in
 - files/assp.in
 - files/patch-assp.pl
 - files/pkg-install.in
 3) the assp.pl patch doesn't end in a new line (see patchset)
 4) :U is used, that's got to be changed to :tu now
 
 In this case, the use of git hurt.  The patchset was blindly generated
 without noticing either the non-function svnid changes or the missing
 carriage return.
 
 I would fix these problems, then submit a new PR that has the words
 "support stage" in the title, with a new patch and then ask for the old
 PR to be closed.  I suggest this approach because ports that support
 stage will be noticed first.

Marino,

I'm working on this today since I have a quiet moment. Any suggest= ions on #3?

Rusty

--=_f10cb3b33d774096f028f3faf853f693--