From owner-freebsd-current@FreeBSD.ORG  Mon May 21 15:57:48 2012
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id F1379106564A
	for <current@freebsd.org>; Mon, 21 May 2012 15:57:48 +0000 (UTC)
	(envelope-from harti@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id C60CD8FC0A
	for <current@freebsd.org>; Mon, 21 May 2012 15:57:48 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q4LFvmC4031661
	for <current@freebsd.org>; Mon, 21 May 2012 15:57:48 GMT
	(envelope-from harti@freefall.freebsd.org)
Received: (from harti@localhost)
	by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q4LFvmP8031660
	for current@freebsd.org; Mon, 21 May 2012 15:57:48 GMT
	(envelope-from harti)
Date: Mon, 21 May 2012 15:57:48 GMT
From: Hartmut Brandt <harti@FreeBSD.org>
Message-Id: <201205211557.q4LFvmP8031660@freefall.freebsd.org>
To: current@freebsd.org
Cc: 
Subject: Syntax error in malloc_np.h
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 21 May 2012 15:57:49 -0000


Hi,

it seems that there is a syntax error in malloc_np.h. It contains lines like:

int	allocm(void **ptr, size_t *rsize, size_t size, int flags)
    __attribute__(nonnull(1));

The problem is that the syntax of the attributes actually requires two
parenthesis:

    __attribute__((nonnull(1)));

Our gcc seems to swallow either of both, but gcc47 chokes on the missing
'(' as does clang++.

Given that we have __nonnull(x) in cdefs.h I suppose the above is better
replaced with __nonnull(1)?

harti