From owner-svn-src-all@freebsd.org Fri May 25 20:09:11 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D613BEF3041 for ; Fri, 25 May 2018 20:09:10 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x232.google.com (mail-io0-x232.google.com [IPv6:2607:f8b0:4001:c06::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5696271FAD for ; Fri, 25 May 2018 20:09:10 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x232.google.com with SMTP id g14-v6so7698764ioc.7 for ; Fri, 25 May 2018 13:09:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=p6A+eMf3r77K707wiDNf8eNxHcjLaCWS+y39QXlr9Cw=; b=g6tb34AtjXDIpbFbTi+FvXlr3uLzgB9z3szeKyZWRYr8fQUkNAytJg74qhI1ocXyqg 9BTEY5rhbZqbQotMrYZlnH6kCbwp+tgqMKEJo+XISzeA6YWAzgNwh9JMSXjuO91ZwrMa gV4G0MXr1EfNjV7xyCTTDdk68yIWtfTMwkAEofGQZdy02WmXjV7TeoS2K1evxaEt35og bK/KoI+Nez/ZEAV3O1V1hIKlTcZpO8OYwl5a48L12yBcuv2EuU8S8BDKY/t7Zta7RK8H aYLC45wptNed2EhTkgZX2G8p4y3dgQb6JVu+r03hXR6HEiyRtg+O/ZHv3HWZnIdmi0DO xWNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=p6A+eMf3r77K707wiDNf8eNxHcjLaCWS+y39QXlr9Cw=; b=Ef3q8aE/X/FV/XGN+5AzX5QHGD6HKwJuySSrXtCguWYHRvLc6tgwoyRN3l+nZ5TBYE zcOqEa/Pa3wZCW6X6rlMbcbiu/U9YOciFw6XM6b3Q71GnX/Xg0koOUPt7pXfLQHFOCuP sxv+k+zyboyo34AR9iIz3bhLrsIJxaje3mK3/fuok/Yb0JkDtzda1P6JE97GBU4WRg3S bpj1T9TF7o/VD6onfWYF9Wn7MxH/wPfit63rAaKGuPUYbsB39YQIktTEJYf//QRKrkhD cYYij2Jqm3VwYuGokMGvlH7CKQ3oiHnsFOzThftRGd9VVA3iYldf8Q5Q5pIvw99COhwC tOmg== X-Gm-Message-State: ALKqPwe34ZjvP9OVvuXfZUuWpAJP/6qSbkj7IK5+i3ObI8C+NcamYS91 hPxkzHSnQ8w4pyVQZaVLPWYnxwqmm97rnFnG+N8dig== X-Google-Smtp-Source: ADUXVKIg5Hy7DNsG2lbWC5jUur//5y+HIrdXzMbByI9lzNHnA+Nzgd3RS4MXFXK+10q16v2++8I/X4pAtY//0p7A+48= X-Received: by 2002:a6b:3846:: with SMTP id f67-v6mr3374531ioa.117.1527278949532; Fri, 25 May 2018 13:09:09 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 2002:a4f:d028:0:0:0:0:0 with HTTP; Fri, 25 May 2018 13:09:08 -0700 (PDT) X-Originating-IP: [50.253.99.174] In-Reply-To: References: <201805250207.w4P275Pf060725@repo.freebsd.org> <20180525151134.GB99063@spindle.one-eyed-alien.net> <20180525174424.GD99063@spindle.one-eyed-alien.net> <20180525182139.GE99063@spindle.one-eyed-alien.net> From: Warner Losh Date: Fri, 25 May 2018 14:09:08 -0600 X-Google-Sender-Auth: pQT_diGslr05k9jvRRfs13vhEU4 Message-ID: Subject: Re: svn commit: r334199 - head/usr.sbin/bhyve To: Ed Maste Cc: Marcelo Araujo , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.26 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 May 2018 20:09:11 -0000 On Fri, May 25, 2018 at 2:02 PM, Ed Maste wrote: > On 25 May 2018 at 14:26, Marcelo Araujo wrote: > > > >> The fact that we don't do NDEBUG builds normally does not allow us to > >> ignore that it exists. It's perfectly reasonable for a user to build > >> with CFLAGS+=NDEBUG. That need to work. If code is going to fail to > >> handle resource errors with NDEBUG set then it needs something like this > >> at the top of the file: > > > > Please document it in some place! > > NDEBUG is documented in assert(3). The man page should have more of an > explanation (and examples) of the possible pitfalls of assert() > though > NDEBUG has been documented in the assert man page since it entered Unix via PBW in the 7th Edition Unix from Bell Labs. It's part of the C standard, as well as many POSIX and SVID docs. Warner